id summary reporter owner description type status priority component severity resolution keywords cc release 3996 [Patch] Wiki mainnav tab does not activate correctly Aaron Camac Ryan J Ollos "It looks like this might have started after Trac implemented this CR [http://trac.edgewall.org/ticket/3655 #3655], no longer supporting changing the request as part of pre_process_request(). This causes the prepare_request() to be called without a handler which cause the activation not to be checked. See callstack below. Just move this to post_process_request(). Attaching suggested change. Tab activation does NOT work {{{ File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/main.py"", line 394, in dispatch_request return _dispatch_request(req, env, env_error) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/main.py"", line 423, in _dispatch_request dispatcher.dispatch(req) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/main.py"", line 173, in dispatch chosen_handler) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/main.py"", line 286, in _pre_process_request chosen_handler = filter_.pre_process_request(req, chosen_handler) File ""/usr/lib/python2.4/site-packages/TracVote-0.1-py2.4.egg/tracvote/__init__.py"", line 139, in pre_process_request self.render_voter(req) File ""/usr/lib/python2.4/site-packages/TracVote-0.1-py2.4.egg/tracvote/__init__.py"", line 180, in render_voter add_script(req, \'vote/js/tracvote.js\') File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/chrome.py"", line 92, in add_script scriptset = req.chrome.setdefault(\'scriptset\', set()) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/api.py"", line 169, in __getattr__ value = self.callbacks[name](self) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/chrome.py"", line 460, in prepare_request self.log.info(traceback.format_stack()) }}} Tab activation does work {{{ File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/main.py"", line 394, in dispatch_request return _dispatch_request(req, env, env_error) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/main.py"", line 423, in _dispatch_request dispatcher.dispatch(req) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/main.py"", line 197, in dispatch resp = chosen_handler.process_request(req) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/ticket/roadmap.py"", line 352, in process_request \'ics\') File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/chrome.py"", line 59, in add_link linkset = req.chrome.setdefault(\'linkset\', set()) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/api.py"", line 169, in __getattr__ value = self.callbacks[name](self) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/util/compat.py"", line 133, in newfunc return func_(*(args + fargs), **dict(kwargs, **fkwargs)) File ""/usr/lib/python2.4/site-packages/Trac-0.11.1-py2.4.egg/trac/web/chrome.py"", line 460, in prepare_request self.log.info(traceback.format_stack()) }}}" defect closed normal VotePlugin normal fixed 0.11