[PATCH] Annoying javascript confirm() and Load button.

[Sébastien GISSINGER]

Could you remove OK/Cancel javascript on ticket type change (new/modify).
Filling automatically textareas with template must be a normal way of doing in your plugin, no need to confirm if i want or/not, i installed the plugin to do it.
In my mind, if people don't like the preformatted template they remove it by themselves but a template is made to be followed not Cancelled.

And could make the same in Admin by removing the Load button. Fill the textarea when changing ticket type automatically. Even if the page blink and you do not intend to do Ajax, i think this a much better way to do.

Mimimizing user interactions must be a standard in software developpement. Users mustn't need to search the information, the information must comme by itself to the user.

Cheers.

[Sébastien GISSINGER]

Some patch files to do what i explained.

There is still a little bad comportment when you first access to Admin > Ticket Template. If the first type selected in the ComboBox is empty (not even a space) it's loaded as is. Or it would load the default ticket template.

To apply these patch files :

• Uninstall old TracTicketTemplatePlugin
• SVN co the sources
• replace old files with these ones
• do a standard TracPlugins installation

[Sébastien GISSINGER]

Replying to sgissinger:

Some patch files to do what i explained.

There is still a little bad comportment when you first access to Admin > Ticket Template. If the first type selected in the ComboBox is empty (not even a space) it's loaded as is. Or it would load the default ticket template.

To apply these patch files :

• Uninstall old TracTicketTemplatePlugin
• SVN co the sources
• replace old files with these ones
• do a standard TracPlugins installation

Could not attach files so external links

​Admin Patch File
​User Patch File

[Sébastien GISSINGER]

Re-open so you can follow it.

[Richard Liao]

It's would be more annoying if user have input a lot of words and replaced by the preformatted template without any warning. The annoying confirm dialog give them a chance to keep their work :)

As for the Load button, your suggestion is a surely good to improve user experience. I will fix it soon.

[Sébastien GISSINGER]

Ok, I didn't notice the confirm being used for this purpose. Hehe in my case, if the user do one mistake he surely won't do a second one. A kind of learning lesson. :)

[Adrian Fritz]

Indicated links are broken. A search at such domain returns nothing. Maybe sgissinger can try reloading files again.

[Steffen Hoffmann]

Replying to AdrianFritz:

Indicated links are broken. A search at such domain returns nothing. Maybe sgissinger can try reloading files again.

Still true; sgissinger, please try again to provide the replacement files here, please.

[alillards]

Replying to richard:

It's would be more annoying if user have input a lot of words and replaced by the preformatted template without any warning. The annoying confirm dialog give them a chance to keep their work :)

I also think the confirmation dialog is annoying, so how about this alternative: If the user has input text in certain fields, ask for confirmation. Else, assume the ticket is empty and apply the template without asking.

[Andras Korn]

Perhaps something like this in templates/tt_newticket.js would do it?

        function onCustomChanged(evt) {
            var tt_name = $("#tt_custom_select").val();
            if (! tt_name) {
                return;
            }

            var ticketType = queryResult.field_value_mapping_custom[tt_name];
            if (typeof ticketType === "undefined") return;
            if (evt.type == "change") {
                var answer = confirm("${_('Replace ticket content with template?')}");
                if (!answer) {
                    return;
                }
            }

            // apply custom template
            _updateTargetElem(ticketType);
        }

[Andras Korn]

Full patch:

0.11/tickettemplate/templates/tt_newticket.js

@@ -196 +196 @@
                 return;
             }
 
+            var ticketType = queryResult.field_value_mapping_custom[tt_name];
+            if (typeof ticketType === "undefined") return;
             if (evt.type == "change") {
                 var answer = confirm("${_('Replace ticket content with template?')}");
                 if (!answer) {
@@ -204 +206 @@
             }
 
             // apply custom template
-            var ticketType = queryResult.field_value_mapping_custom[tt_name];
             _updateTargetElem(ticketType);
         }
 
@@ -333 +334 @@
                 return;
             }
 
+            var ticketType = queryResult.field_value_mapping_custom[tt_name];
+            if (typeof ticketType === "undefined") return;
             if (evt.type == "change" && isLoad == false) {
                 var answer = confirm("${_('Replace ticket content with template?')}");
                 if (!answer) {
@@ -340 +343 @@
                 }
             }
 
-            var ticketType = queryResult.field_value_mapping[tt_name];
             if (!ticketType) {
                 ticketType = queryResult.field_value_mapping['default'];
             }

Appears to work on first sight.

[brian@…]

Replying to chester_copperpot:

I also think the confirmation dialog is annoying, so how about this alternative: If the user has input text in certain fields, ask for confirmation. Else, assume the ticket is empty and apply the template without asking.

Agreed! The confirmation dialog is only annoying when it has no possibility of deleting user data. #11544 should be considered with any changes to the confirm behavior.