Modify ↓

Opened 14 years ago

Closed 6 years ago

#6647 closed defect (fixed)

[Patch] Voting gets unnecessarily caught by FlashBlock extensions

Reported by: ibboard Owned by: Ryan J Ollos
Priority: high Component: FiveStarVotePlugin
Severity: minor Keywords:
Cc: Trac Release: 0.11

Description (last modified by Ryan J Ollos)

I've got a FlashBlock script that replaces all <object> tags with a "blocked" element. Even though this hack just uses HTML and JS (although the JS seems superfluous) it gets blocked because of the <object> tag, which is normally used for Flash and the like.

To fix it I just replaced 

add_ctxtnav(req, tag.span(tag.object(ul), id='fivestarvotes', title=title, class_=className))

with 

add_ctxtnav(req, tag.span(ul, id='fivestarvotes', title=title, class_=className))

in __init.py__

Attachments (1)

fivestarvote.diff​ (4.1 KB) - added by ibboard 14 years ago.
Diff of cleaned up code and fixed XHTML generation

Download all attachments as: .zip

Change History (11)

comment:1 Changed 14 years ago by anonymous

Actually, that fix doesn't work because a <span> shouldn't contain a block-level element such as <ul>. I'll attach a fix that is valid XHTML and cleaner code (no links when they're not needed, no unnecessary duplication, etc).

Version 0, edited 14 years ago by anonymous (next)

Changed 14 years ago by ibboard

Attachment: fivestarvote.diff​ added

Diff of cleaned up code and fixed XHTML generation

comment:2 Changed 14 years ago by Ryan J Ollos

Owner: changed from Dav Glass to Ryan J Ollos

comment:3 Changed 14 years ago by Ryan J Ollos

Summary: Voting gets unnecessarily caught by FlashBlock extensions → [Patch] Voting gets unnecessarily caught by FlashBlock extensions

comment:4 Changed 13 years ago by Ryan J Ollos

Priority: low → high
Status: new → assigned

comment:5 Changed 12 years ago by Ryan J Ollos

Status: assigned → new

comment:6 Changed 6 years ago by Ryan J Ollos

Status: new → accepted

comment:7 Changed 6 years ago by Ryan J Ollos

In 16935:

FiveStarVote 0.1.1: Don't use $ at global scope

Refs #6647.

comment:8 Changed 6 years ago by Ryan J Ollos

In 16936:

FiveStarVote 0.1.1: Conform to PEP8

Refs #6647.

comment:9 Changed 6 years ago by Ryan J Ollos

Description: modified (diff)

comment:10 Changed 6 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

In 17155:

FiveStarVote 0.2.0dev: Make compatible with Trac 1.2+

  • Trac < 1.0 is no longer supported.
  • Modify context nav HTML per patch by ibboard.

Fixes #6647.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.