Opened 14 years ago
Last modified 6 years ago
#6647 closed defect
[Patch] Voting gets unnecessarily caught by FlashBlock extensions — at Version 9
| Reported by: | ibboard | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | high | Component: | FiveStarVotePlugin |
| Severity: | minor | Keywords: | |
| Cc: | Trac Release: | 0.11 |
Description (last modified by )
I've got a FlashBlock script that replaces all <object> tags with a "blocked" element. Even though this hack just uses HTML and JS (although the JS seems superfluous) it gets blocked because of the <object> tag, which is normally used for Flash and the like.
To fix it I just replaced
add_ctxtnav(req, tag.span(tag.object(ul), id='fivestarvotes', title=title, class_=className))
with
add_ctxtnav(req, tag.span(ul, id='fivestarvotes', title=title, class_=className))
in __init.py__
Change History (10)
Changed 14 years ago by
| Attachment: | fivestarvote.diff added |
|---|
Diff of cleaned up code and fixed XHTML generation
comment:2 Changed 14 years ago by
| Owner: | changed from Dav Glass to Ryan J Ollos |
|---|
comment:3 Changed 14 years ago by
| Summary: | Voting gets unnecessarily caught by FlashBlock extensions → [Patch] Voting gets unnecessarily caught by FlashBlock extensions |
|---|
comment:4 Changed 13 years ago by
| Priority: | low → high |
|---|---|
| Status: | new → assigned |
comment:5 Changed 12 years ago by
| Status: | assigned → new |
|---|
comment:6 Changed 6 years ago by
| Status: | new → accepted |
|---|
comment:9 Changed 6 years ago by
| Description: | modified (diff) |
|---|
Note: See
TracTickets for help on using
tickets.
Actually, that fix doesn't work because a
<span>shouldn't contain a block-level element such as<ul>. I'll attach a fix that is valid XHTML and cleaner code (no links when they're not needed, no unnecessary duplication, etc).