Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#8953 closed defect (duplicate)

Absolute href are broken if trac is installed in root path — at Version 1

Reported by: anonymous Owned by: Catalin BALAN
Priority: normal Component: MenusPlugin
Severity: normal Keywords: href
Cc: Trac Release: 0.12

Description (last modified by Ryan J Ollos)

Hi,

If an absolute href is broken trac is installed at root of the domain.

For exemple, if you install your trac at http://trac.myproject.org/ and configure

[mainnav]
wiki.href = /wiki/Home

then TracMenus generates href 'wiki/Home'. This broke the link. (wiki is a netloc).

The offending code is : http://trac-hacks.org/browser/menusplugin/0.11/tracmenus/web_ui.py#L139

menu[name]['label']=menu[name].setdefault('label', html.a())(href=value.startswith('/') and req.href()+value or value)

reg.href() returns '/'. You should trim beginning '' in the resulting href.

Regards, Étienne

Change History (1)

comment:1 Changed 12 years ago by Ryan J Ollos

Description: modified (diff)
Resolution: duplicate
Status: newclosed

Duplicate of #8877, but thanks for the hint at a solution.

Note: See TracTickets for help on using tickets.