Changes between Initial Version and Version 1 of Ticket #9606, comment 30


Ignore:
Timestamp:
Sep 25, 2019, 4:35:54 AM (10 months ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9606, comment 30

    initial v1  
    44It appears that `Layout.update` (which calls `Layout.order_fields`) is being called repeatedly. It looks to me like the layout should be updated just once, after applying all the rules. As a further optimization, we could have the rules set a flag that determines if the layout needs to be updated, in order to avoid unnecessary updates.
    55
    6 I tried the following patch, but the layout is not applied correctly. Some fields incorrectly end up with their own row. I will continue to investigate whether this is a valid approach. Jun, do you think this approach should work?
     6I tried the following patch, which makes the update very fast, but the layout is not applied correctly. Some fields incorrectly end up with their own row. I will continue to investigate whether this is a valid approach. Jun, do you think this approach should work?
    77
    88{{{#!diff