Changes between Version 3 and Version 4 of CodeReviewPlugin/Concepts


Ignore:
Timestamp:
Oct 10, 2017, 9:07:53 AM (7 years ago)
Author:
figaro
Comment:

Further cosmetic changes, removed erroneous keyword proposal

Legend:

Unmodified
Added
Removed
Modified

  • CodeReviewPlugin/Concepts

    v3 v4  
     1[[PageOutline(2-5,Contents,pullout)]]
     2
    13= CodeReviewPlugin Concepts
    24
    … …  
    46
    57 * Whenever a changeset is displayed, review information is available:
    6   * Reviewer
    7   * Review result description
    8   * Review result state: ACCEPTED or REJECTED
    9  * When the user has the permission CODE_REVIEW, this information is editable
    10   * A button named "Review" is saving the information and setting Reviewer to the current user
    11  * When the user lacks the permission CODE_REVIEW, this information is read-only
     8  * Reviewer.
     9  * Review result description.
     10  * Review result state: ACCEPTED or REJECTED.
     11 * When the user has the permission CODE_REVIEW, this information is editable.
     12  * A button named "Review" is saving the information and setting Reviewer to the current user.
     13 * When the user lacks the permission CODE_REVIEW, this information is read-only.
    1214 * Reviews are also available from "View Tickets", if you add a report on the table CODEREVIEW.
    1315  * To make this easier, besides the changeset revision, the changeset author is also redundantly store in this table.
    … …  
    4749  * Show each review by author (allow multiple reviewers)
    4850  * only show the review outcome (accepted, rejected, ...make this configurable?) as a link to the full review text as a wiki page/section of a page (maybe 1 page per changeset, 1 heading section per file?)
    49    * This allows a code review summary to just be a print of a wiki page, or, a print of all the sub page via, say, Wiki-Print
     51   * This allows a code review summary to just be a print of a wiki page, or, a print of all the sub page via, say, Wiki-Print.
    5052 * changeset string format could be something as simple as CR:REVNUM:File:Author:result as the property name, then the comments.
    5153   * then on the annotation hover, parsed into: (in pseudo code)
    … …  
    6264}}}
    6365
    64 Now I realize this is tied to subversion, but could some of these ideas be incorporated into this DB based implementation.
     66Now I realize this is tied to Subversion, but could some of these ideas be incorporated into this database based implementation.