Version 2 (modified by 3 years ago) (diff) | ,
---|
Categories
Review of Changesets
There is support for reviews of changesets. The user may create a review on the changeset page and all modified files are automatically gathered and attached to the new review.
The review may be done either on the changeset page or using the dedicated review pages provided by the plugin.
Creating the review
A new section is inserted into the changeset page when the current user has sufficient permissions to create a review.
After selecting users it is possible to create the new review.
Review details
Details about the review are shown in the overview section of the changeset page. There is a direkt link to open the review page.
Perform the Review
It's not necessary to leave the changeset page to perform a review. Every line number of the source file view is a link which opens a dialog to add a comment.
It is possible to reply to existing comments. The user may chose the presentation of the file view, either inline
or side by side
.
Notes
- Files which were added or moved with this changeset are only shown as links in the overview section. A file view is not available. Such files must be reviewed using the
Code Review
page provided by the plugin. - You can't add user groups to a review. This means, you can't grant code review permissions to e.g.
anonymous
. This is a known limitation (see also #12782). - To use more advanced features like review workflows you have to open the review page.
Attachments (5)
-
codereview_changeset_create.png (239.1 KB) - added by 3 years ago.
Screenshot of creating a review on the changeset page.
-
codereview_changeset_info.png (196.2 KB) - added by 3 years ago.
Screenshot of code review info on changeset page.
-
codereview_create_comment_inline.png (133.2 KB) - added by 3 years ago.
Screenshot of comment dialog.
-
codereview_comment_tree.png (117.9 KB) - added by 3 years ago.
Screenshot of comment tree in side by side view
-
codereview_changeset_reviewpage.png (232.8 KB) - added by 3 years ago.
Screenshot of review page for a changeset
Download all attachments as: .zip