Changes between Initial Version and Version 1 of Ticket #11165, comment 4


Ignore:
Timestamp:
Jun 15, 2013, 12:13:36 AM (11 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11165, comment 4

    initial v1  
    33Summary of changes:
    44
    5 1) get_num_closed_tix and get_num_open_tix in this version ONLY read from the ticket table, and infer open/closed states based on status, time, and changetime.  While less than ideal for getting 100% accurate dates, it does now result in accurate counts, which is more important for my use case.
    6 
    7 2) The date loop calculation logic has been fixed - there were multiple bugs.
    8    a) Using datetime.now() returns local time, but the other calculations used UTC explicitly - this is changed to .utcnow() for consistency
    9    b) Fixed the values being passed to date_range in the for loop to gather data points
    10    c) By fixing (b), was able to remove the strange +12hrs being appended to at_date
    11    d) Changed date_str to be last_date, since that's actually the number a user wants to see
     5 1. get_num_closed_tix and get_num_open_tix in this version ONLY read from the ticket table, and infer open/closed states based on status, time, and changetime.  While less than ideal for getting 100% accurate dates, it does now result in accurate counts, which is more important for my use case.
     6 1. The date loop calculation logic has been fixed - there were multiple bugs.
     7  1. Using datetime.now() returns local time, but the other calculations used UTC explicitly - this is changed to .utcnow() for consistency
     8  1. Fixed the values being passed to date_range in the for loop to gather data points
     9  1. By fixing (b), was able to remove the strange +12hrs being appended to at_date
     10  1. Changed date_str to be last_date, since that's actually the number a user wants to see