Changes between Version 2 and Version 3 of CodeReviewPlugin/Concepts
- Timestamp:
- Nov 4, 2015, 10:58:49 AM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
CodeReviewPlugin/Concepts
v2 v3 1 = CodeReviewPlugin Concepts =1 = CodeReviewPlugin Concepts 2 2 3 == Basic idea == 3 == Basic idea 4 4 5 * Whenever a changeset is displayed, review information is available: 5 6 * Reviewer … … 12 13 * To make this easier, besides the changeset revision, the changeset author is also redundantly store in this table. 13 14 14 == Ideas == 15 ( If approved, turn them to tickets and mark them here accordingly. ) 15 == Ideas 16 17 If approved, turn them to tickets and mark them here accordingly. 16 18 17 19 * Send an email to the author, whenever a changeset is REJECTED. … … 41 43 with that: 42 44 My original idea was to save the reviews to the subversion changeset via properties with some simple formatting, and: 43 * Also suggest a link to code review, if present, when a list if files is presented for large changesets (right next to "view diffs")44 * Modify the Annotation view template to parse the special properties, and pull out reviews specific to the current file/selected revision and 45 * Also suggest a link to code review, if present, when a list if files is presented for large changesets, right next to "view diffs". 46 * Modify the Annotation view template to parse the special properties, and pull out reviews specific to the current file/selected revision and: 45 47 * Show each review by author (allow multiple reviewers) 46 48 * only show the review outcome (accepted, rejected, ...make this configurable?) as a link to the full review text as a wiki page/section of a page (maybe 1 page per changeset, 1 heading section per file?) 47 49 * This allows a code review summary to just be a print of a wiki page, or, a print of all the sub page via, say, Wiki-Print 48 50 * changeset string format could be something as simple as CR:REVNUM:File:Author:result as the property name, then the comments. 49 * then on the annotation hover, parsed into: (in pseudo code , sorry, not sure how else to convey the idea)51 * then on the annotation hover, parsed into: (in pseudo code) 50 52 {{{ 51 53 for all properties on changeset REVNUM: … … 61 63 62 64 Now I realize this is tied to subversion, but could some of these ideas be incorporated into this DB based implementation. 63 Also, I apologize for the verboseness of this, not sure what the best way to convey these concepts in compact form.