Changes between Version 18 and Version 19 of CodeReviewerPlugin


Ignore:
Timestamp:
Sep 22, 2012, 9:00:23 PM (2 years ago)
Author:
rjollos
Comment:

Added some syntax highlighting.

Legend:

Unmodified
Added
Removed
Modified
  • CodeReviewerPlugin

    v18 v19  
    2222 1. Install the plugin (after downloading and unzipping):
    2323    {{{
     24    #!sh
    2425    cd codereviewerplugin/0.12
    2526    sudo python setup.py bdist_egg
     
    3132 2. Enable the plugin ''and'' if using the built-in {{{commit-updater}}}, disable {{{CommitTicketReferenceMacro}}}:
    3233    {{{
     34    #!ini
    3335    [components]
    3436    tracopt.ticket.commit_updater.committicketupdater = enabled
     
    4143 3. (''optional'') Customize the names for the three statuses (make sure there are always exactly three in the shown order of meaning):
    4244    {{{
     45    #!ini
    4346    [codereviewer]
    4447    status_choices = REJECTED,PENDING,PASSED
     
    4750 4. After the above, run:
    4851    {{{
     52    #!sh
    4953    sudo trac-admin /path/to/projenv upgrade
    5054    }}}
     
    8084If you wanted to prevent the {{{phase}}} from moving beyond "codereview" until all pending code reviews were completed and the last changeset passed review, then if using this plugin's commit ticket reference macro you can add the following [wiki:DynamicFieldsPlugin DynamicFields plugin] rules:
    8185    {{{
     86    #!ini
    8287    [ticket-custom]
    8388    phase.invalid_if.1 = verifying
     
    97102You can configure this plugin to trigger a Jenkins job (or any command) in {{{trac.ini}}}:
    98103{{{
     104#!ini
    99105[codereviewer]
    100106command = curl http://jenkins.example.com/job/stage_deploy/build?token=mytoken
     
    109115You can also add "completeness" criteria to determine when a ticket is actually complete and ready for deployment.  For example, if your workflow encourages ongoing code reviews on tickets that may not be fully complete, you can specify one or more ticket fields to use as additional criteria to determine completeness in {{{trac.ini}}}:
    110116{{{
     117#!ini
    111118[codereviewer]
    112119completeness = phase=(codereview|verifying|releasing)
     
    121128You can have code review submissions automatically change fields of completed tickets.  Continuing the workflow example from above, if a ticket's custom phase field gets set to "codereview" and reassigned to a reviewer, the reviewer may typically send the ticket back to "implementation" and the author after a failed review.  The plugin can do this automatically via specifying this in {{{trac.ini}}}:
    122129{{{
     130#!ini
    123131[codereviewer]
    124132failed = phase=implementation,owner={author}