Modify

Opened 2 years ago

Closed 22 months ago

#10229 closed defect (fixed)

does not work with error message "Path not specified"

Reported by: uray Owned by: rjollos
Priority: normal Component: PlantUmlMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

macro revision is r11721, trac version is 0.11.7, test use example from https://trac-hacks.org/wiki/PlantUmlMacro#Usage, the error is from macro.py, line 97, checked the variable 'args', the value is "{'class': 'wikipage'}" (should be "None" I think).

Attachments (0)

Change History (9)

comment:1 Changed 2 years ago by uray

  • Trac Release changed from 0.12 to 0.11

fix Trac Release to 0.11

comment:2 Changed 2 years ago by rjollos

  • Owner changed from airadier to rjollos

Thanks for reporting. I thought I had this fixed in #10144, but I suppose not. Differentiating between a macro and WikiProcessor call in Trac 0.11.x has been tricky. Trac 0.12 has an argument that makes this differentiation simple, but we want to keep support 0.11.x for now.

I'll setup some unit tests and see if I can finally get this fixed finally later this week.

comment:3 Changed 2 years ago by rjollos

  • Cc rjollos removed

Sorry for letting this go for so long. I hope to address the issue this weekend.

comment:4 Changed 2 years ago by rjollos

  • Priority changed from normal to high
  • Status changed from new to assigned

comment:5 Changed 23 months ago by anonymous

Is there a workaround on this? I have Trac installation 0.11.7 and plugin reports "Path not specified", this makes plugin unusable.

comment:6 Changed 23 months ago by anonymous

  • Priority changed from high to normal

I was able to reproduce with Trac 0.11.7. I developed with Trac 0.11 and Trac 1.0dev, but the error is not seen on those Trac versions, so that is how it slipped by my previous testing.

The issue should be fixed with the next checkin. Please report back if you can. I'll setup proper unit tests after we workout how to setup the test harness in #10612.

comment:7 Changed 23 months ago by rjollos

(In [12389]) Refs #10229, #7053:

  • Fixed error reported on Trac 0.11.7 in which calls containing the uml in the body of the wikiprocessor would fail with Path not specified.
  • A message with the file path is now reported when the file is not found in the repository.

comment:8 Changed 22 months ago by anonymous

Updating to newest revision fixed the problem for me, thanks!

comment:9 Changed 22 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

Thanks. Sorry that took so long.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.