Desc/Asc sort issue

[sdegrande]

Changing the ascending/descending sort order of a column (via the triangular arrows on the HTML table, or via the configuration parameters in trac.ini) has no impact.

The proposed attached patch fixes that issue.

Thanks for your great work !

[sdegrande]

I was not able to attach a file on the ticket, so here is the diff:

downloadsplugin/0.12/tracdownloads/api.py

@@ -502 +502 @@
                 if context.req.args.has_key('desc'):
                     desc = context.req.args.get('desc') == '1'
                 else:
-                    desc = self.download_sort_direction
+                    desc = self.download_sort_direction == 'desc'
 
                 self.data['order'] = order
                 self.data['desc'] = desc
@@ -533 +533 @@
                 if context.req.args.has_key('desc'):
                     desc = context.req.args.get('desc') == '1'
                 else:
-                    desc = self.download_sort_direction
+                    desc = self.download_sort_direction == 'desc'
                 download_id = int(context.req.args.get('download') or 0)
 
                 self.data['order'] = order
@@ -630 +630 @@
                 if context.req.args.has_key('desc'):
                     desc = context.req.args.get('desc') == '1'
                 else:
-                    desc = self.architecture_sort_direction
+                    desc = self.architecture_sort_direction == 'desc'
                 architecture_id = int(context.req.args.get('architecture') or 0)
 
                 # Display architectures.
@@ -683 +683 @@
                 if context.req.args.has_key('desc'):
                     desc = context.req.args.get('desc') == '1'
                 else:
-                    desc = self.platform_sort_direction
+                    desc = self.platform_sort_direction == 'desc'
                 platform_id = int(context.req.args.get('platform') or 0)
 
                 # Display platforms.
@@ -736 +736 @@
                 if context.req.args.has_key('desc'):
                     desc = context.req.args.get('desc') == '1'
                 else:
-                    desc = self.type_sort_direction
+                    desc = self.type_sort_direction == 'desc'
                 platform_id = int(context.req.args.get('type') or 0)
 
                 # Display platforms.

[rjollos]

Replying to sdegrande:

Changing the ascending/descending sort order of a column (via the triangular arrows on the HTML table, or via the configuration parameters in trac.ini) has no impact.

My observation was that changing the sort direction by clicking on the arrow worked correctly, but setting the option in trac.ini had no effect.

[rjollos]

(In [12067]) Fixes #10280: FIX: specifying a sort direction in trac.ini had no effect. Thanks to sdegrande for the patch.

Removed egg accidentally committed in [12064].

[rjollos]

Please report back if you have a chance to test the latest trunk. Note the directory reoganization in [12063:12066].

[sdegrande]

Replying to rjollos:

Please report back if you have a chance to test the latest trunk. Note the directory reoganization in [12063:12066].

I'll will do ASAP.

Thanks for your work.

[sdegrande]

Replying to sdegrande:

Replying to rjollos:

Please report back if you have a chance to test the latest trunk. Note the directory reoganization in [12063:12066].

I'll will do ASAP.

Thanks for your work.

I just tested r12139.

Works well. Thanks.