Opened 9 months ago
Last modified 5 days ago
#10326 new enhancement
Make compatible with Trac 1.0
| Reported by: | rjollos | Owned by: | rjollos |
|---|---|---|---|
| Priority: | normal | Component: | BacklogPlugin |
| Severity: | normal | Keywords: | database cursor scope |
| Cc: | anachesa, bart | Trac Release: | 1.0 |
Description (last modified by rjollos)
Implement changes to make the plugin compatible with Trac 0.12 through 1.0.
Attachments (1)
Change History (12)
comment:1 Changed 9 months ago by rjollos
- Status changed from new to assigned
Changed 9 months ago by rjollos
comment:2 Changed 9 months ago by rjollos
comment:3 Changed 9 months ago by rjollos
(In [11996]) Refs #8653, #10326 (0.1.34) Numerous fixes for compatibility with Trac 0.12 and 1.0:
- Fix for possible cannot operate on closed cursor error. The db object could be cleaned up before the cursor is used in the try/catch. This does not seem to happen if the db object is passed as a parameter though, so the _create_ordering_table function was changed from a private member function of the BacklogModule class, to a private function of the web_ui module.
- Assignments were made to the following variables for no apparent reason, as they were not being used: data['req'] and data['args']. The assignment data['req'] was causing problems as it was overwriting the req object in the template space, leading to a traceback, but only under Trac 1.0 (ticket/10326).
- The unique attribute of a Column was removed in Trac 0.12, and a traceback was resulting from its use (ticket/10326). The attribute actually had no effect in Trac 0.11 anyway ([t 9406/trunk/trac/db/schema.py]).
- The env member variable of the BacklogListclass was being used, but was never assigned, resulting in a traceback (ticket/8653).
comment:4 Changed 9 months ago by rjollos
comment:5 Changed 9 months ago by rjollos
comment:6 Changed 9 months ago by rjollos
comment:7 Changed 9 months ago by rjollos
- Keywords database cursor scope added
comment:8 follow-up: ↓ 10 Changed 9 months ago by rjollos
We now have full compatibility with Trac 0.12 and 1.0, with the exception of a timestamp vs utimestamp issue, which was brought up and will be addressed in #8653.
Please comment in this ticket if you've had the opportunity to test. I'll leave this ticket open for a while and eventually bump the plugin version to 0.2.0.
comment:9 Changed 9 months ago by rjollos
- Description modified (diff)
- Type changed from task to enhancement
I'm not sure why [11999] shows just 4 of the several existing files being copied in addition to the move on backlogplugin/0.11. It seems like a bug in Trac or SVN.
comment:10 in reply to: ↑ 8 Changed 9 months ago by rjollos
comment:11 Changed 5 days ago by rjollos
- Status changed from assigned to new



Here is one issue, which I'll commit a fix for shortly: