Modify

Opened 23 months ago

Last modified 13 months ago

#10329 new task

Refactor and redesign

Reported by: rjollos Owned by: rjollos
Priority: normal Component: BacklogPlugin
Severity: normal Keywords:
Cc: anachesa, bart Trac Release: 0.11

Description

Refactoring and redesign will be done against this ticket, for the 0.2 version of the plugin.

Attachments (0)

Change History (7)

comment:1 Changed 22 months ago by rjollos

Just a note to self: backlog.db looks like it was copied from fullblog.db and modified.

comment:2 Changed 22 months ago by rjollos

  • Status changed from new to assigned

The following error is seen in the javascript error console:

Resource interpreted as Script but transferred with MIME type
text/x-javascript: "http://localhost:8000/tracdev/chrome/backlog/js
/jquery-ui-1.7.2.custom.min.js".

comment:3 Changed 22 months ago by rjollos

(In [12005]) Refs #10329:

  • Several instances in which the passing of a cursor object was replaced with passing a db object. This avoid potential problems with the cursor being invalid.
  • Removed duplicated "save order"/"reset"/"delete closed" controls on the backlog page.
  • Having BACKLOG_MODIFY* permission now grants BACKLOG_VIEW permission.
  • Removed trailing whitespace and formatted source code.
  • Added encoding and copyright info to top of each file.
  • Added placeholder COPYING file.
  • Added changelog.

comment:4 Changed 22 months ago by rjollos

I see this error even when the user has the specified permission:

BACKLOG_MODIFY_PRODUCT_AND_COMMUNITY privileges are required to perform this operation. You don't have the required permissions.

Inspecting the perm._cache field, the user has only the BACKLOG_VIEW permission. I think there is something fundamentally wrong with how the permissions are generated. Besides, generating numerous permissions like this is not the way to implement fine-grained permissions. I'll eliminate the per-backlog permission for now, but they will be restored later on.

comment:5 Changed 22 months ago by rjollos

(In [12008]) Refs #10329:

  • Upgraded jQuery UI from 1.7.2 to 1.7.3, which resolved the mimetype issue described in comment:2. It is unlikely the upgrade itself fixed the issue; rather it may have been resolved simply by including a clean instance of jQuery UI 1.7.2.
  • FIX: The form controls were moved outside of the enclosing form elements in [12005], which caused them to stop working.
  • FIX: The class backlog was being used in multiple places within the backlog and backlog_list templates, which resulted in all of the elements being movable on the backlog page.
  • The dynamically-generated permission set was causing problems described in comment:4. In the future, fine-grained permissions will be implemented as part of the redesign. For now, the permission set is BACKLOG_VIEW, BACKLOG_MODIFY, BACKLOG_OWNER and BACKLOG_ADMIN.

comment:6 Changed 22 months ago by rjollos

(In [12009]) Refs #10329:

  • Added images that should have been included in [12008].
  • Fixed some whitespace and tab/space issues.

comment:7 Changed 13 months ago by rjollos

  • Status changed from assigned to new

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.