Modify

Opened 2 years ago

Closed 2 years ago

Last modified 9 months ago

#10357 closed defect (fixed)

AttributeError: 'list' object has no attribute 'split'

Reported by: neil.cutcliffe@… Owned by: robguttman
Priority: normal Component: CodeReviewerPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (last modified by rjollos)

I installed CodeReviewerPlugin on Trac 0.12.2, then saw this error in trac.log:

2012-09-20 11:50:47,919 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/Trac-0.12.2-py2.6.egg/trac/web/main.py", line 511, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.6/site-packages/Trac-0.12.2-py2.6.egg/trac/web/main.py", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File "build/bdist.linux-i686/egg/coderev/web_ui.py", line 76, in process_request
    review = CodeReview(self.env, repo, changeset, req)
  File "build/bdist.linux-i686/egg/coderev/model.py", line 33, in __init__
    self.statuses = statuses.split(',') if statuses else self.STATUSES
AttributeError: 'list' object has no attribute 'split'
2012-09-20 11:50:48,374 Trac[main] DEBUG: Dispatching <Request "GET '/chrome/coderev/coderev.js'">

I worked around the error by removing the call to 'split'. This disabled the feature for custom names of the three statuses. No problem, I'm ok with the default names.

[ncutcliffe@andy coderev]$ diff model.py- model.py
33c33
<         self.statuses = statuses.split(',') if statuses else self.STATUSES
---
>         self.statuses = self.STATUSES

I suspect this error is related to the various versions of Python, Trac and/or CodeReviewer on my server. But this is my first experience with Python and I don't know what versions to check. I would be glad to provide more info on request.

Attachments (0)

Change History (4)

comment:1 Changed 2 years ago by rjollos

  • Description modified (diff)

comment:2 Changed 2 years ago by robguttman

(In [12049]) refs #10357: handle no codereviewer section in trac.ini.

comment:3 Changed 2 years ago by robguttman

  • Resolution set to fixed
  • Status changed from new to closed

Neil, thanks for submitting this bug report - you found a legit bug. Now fixed. Please download and try latest version and let me know if you have any more problems.

comment:4 Changed 9 months ago by rjollos

In 13696:

Bump version to 0.0.3. Refs #10357, #10834.

Add Comment

Modify Ticket

Action
as closed The owner will remain robguttman.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.