Modify

Opened 19 months ago

Last modified 19 months ago

#10420 new enhancement

SVN commit log analysis in the new post-commit-hook world

Reported by: fommil Owned by: bobbysmith007
Priority: normal Component: TimingAndEstimationPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

I just love the new trac 1.0, I upgraded from 0.11 but the whole post-commit-hook architecture seems to have been rewritten.

I don't have access to this plugin right now but I would like to know if the new hooks are supported, and if so where in the code this is handled?

e.g. use start timer on ticket page and then commit with log "fixes #number"

I'd actually like to be able to have the explicit log functionality working even if the plugin is not installed (say there is a custom field called hours)

e.g. fixes #number (27m)

where would be the place to look for that?

Attachments (0)

Change History (4)

comment:1 Changed 19 months ago by bobbysmith007

I have not rewritten my trac post commit hooks in the new style (I still just use the old style). Mine just interact with trac by importing python modules and using them trac-post-commit script. It is still being invoked explicitly from the hooks of my git and svn repositories.

The timer on the T&E page is all javascript, so by default I don't think your post-commit hooks can interact with that.

I'm not totally sure what else you are asking.

comment:2 Changed 19 months ago by fommil

Oh, apologies, maybe I'm getting this mixed up with functionality from another plugin. I thought this plugin had support for:

  1. a custom post-commit-hook which parsed bracketed numbers (into the "hours" field) as well as the standard trac hook behaviour
  1. a button in the ticket page to signal that a user had started to work on a ticket. If the post-commit-hook is activated when this is clicked, then the "hours" field is updated based on the elapsed time (no need to write it in the commit log) and the ticket is potentially closed.

I'm going by memory, but I'm not sure if what I seen in 2 was the timer. I recall it being more of a "I am starting to work on this now" button and there was no need to keep the page open. I might has simply misinterpreted the actual functionality for this in my mind, as I thought this would be the sensible behaviour (requiring the least amount of developer input but capturing the essential information).

comment:3 Changed 19 months ago by bobbysmith007

  1. a custom post-commit-hook which parsed bracketed numbers (into the "hours" field) as well as the standard trac hook behaviour

This exists and is what I linked to, but was done using the style from before trac12

  1. a button in the ticket page to signal that a user had started to work on a ticket. If the post-commit-hook is activated when this is clicked, then the "hours" field is updated based on the elapsed time (no need to write it in the commit log) and the ticket is potentially closed.

I didn't write the timer (it was a user submitted patch) but i believe it does every thing on the client with javascript.

comment:4 Changed 19 months ago by fommil

Advice on how to implement this for the new commit hooks: https://groups.google.com/d/topic/trac-users/I3Wr32bHEg0/discussion

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.