Modify

Opened 22 months ago

Closed 4 days ago

Last modified 2 days ago

#10423 closed defect (fixed)

Uses schema versions instead of ugly db table existence test

Reported by: hasienda Owned by: rjollos
Priority: normal Component: WatchlistPlugin
Severity: major Keywords: AttributeError upgrade db
Cc: rjollos Trac Release: 1.0

Description

Plugin's schema version check relies on a depreciated way of plugin db schema version checking. It risks exceptions on execution of the SELECT SQL statement in absence of the corresponding db table in tracwatchlist.db.settings_table_exists.

The issue has been discussed for Trac in t:#10451, after raised for TagsPlugin in #9521.

A working solutions was implemented in [10800:12077], but this is still WiP (see https://groups.google.com/d/topic/trac-dev/jL0LbLvEl-M/discussion as well).

Fixing this will be critical for Trac-1.0 compatibility.

Attachments (0)

Change History (4)

comment:1 Changed 22 months ago by hasienda

  • Cc rjollos added

I'll have a closer look when working on AnnouncerPlugin again. Feel free to contact me earlier for discussion as needed.

comment:2 Changed 4 days ago by rjollos

  • Owner changed from martin_s to rjollos
  • Status changed from new to accepted

comment:3 Changed 4 days ago by rjollos

  • Resolution set to fixed
  • Status changed from accepted to closed

In 14022:

Fix test for table existence in Trac 1.0 and later. Fixes #10423.

comment:4 Changed 2 days ago by hasienda

Looks good, thanks.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.