Ticket #10664 (closed defect: fixed)

Opened 6 months ago

Last modified 3 months ago

[PATCH] AdminEnumListPlugin does not work on Firefox 17 with Trac 0.12.4

Reported by: jun66j5 Assigned to: rjollos
Priority: normal Component: AdminEnumListPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

When visiting admin panel, I got the following error.

Timestamp: 2012-11-30 12:52:36
Error: TypeError: a.attributes is null
Source File: http://example.org:3000/chrome/common/js/jquery.js
Line: 55

After applying the following patch, it works well on Firefox 17. Also, I confirmed with Chrome 24 beta, IE 8.

Index: adminenumlistplugin/htdocs/adminenumlist.js
===================================================================
--- adminenumlistplugin/htdocs/adminenumlist.js (revision 12395)
+++ adminenumlistplugin/htdocs/adminenumlist.js (working copy)
@@ -14,7 +14,7 @@

        //IE Doesn't stop selecting text when mousedown returns false we need to check
        // That onselectstart exists and return false if it does
-       var hasOnSelectStart = typeof $(document).attr('onselectstart') != 'undefined';
+       var hasOnSelectStart = document.onselectstart !== undefined;

        // Indicates whether we're dragging a row
        var dragging = false;

Attachments

Change History

12/08/12 08:58:03 changed by rjollos

  • owner changed from nonplus to rjollos.
  • status changed from new to assigned.

12/09/12 11:25:10 changed by rjollos

(In [12420]) Refs #10664: Check for existence of onselectstart function was not compatible with all browsers. Patch by Jun Omae (jun66j5).

02/17/13 04:08:46 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to fixed.

Add/Change #10664 ([PATCH] AdminEnumListPlugin does not work on Firefox 17 with Trac 0.12.4)




Change Properties
Action