Ticket #10666 (closed defect: fixed)

Opened 6 months ago

Last modified 2 months ago

Error logging typo

Reported by: myingling Assigned to: sandinak
Priority: normal Component: DirectoryAuthPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description (Last modified by rjollos)

Line 116 (r12025) of auth.py prints a log message, but has a typo since it only provides one string, but indicates two will print. 

self.log.debug('Unable to find user %s listed in group: %s' % str(m))

This looks like a trivial bug, though I'm not clearly seeing which variable contains the user name. In the meantime I can remove a '%s' to make the bug go away.

A similar bug (new ticket?) shows up at lines 500-509. Data is stored to variable 'res' or an exception is thrown which prints a long message. Then execution can continue, but even if the exception was thrown, the variable is still accessed at 506.

The end results of each of these issues is that that Trac loads with an error, but the error looks like a bug in the plugin, not a configuration issue (which becomes visible when you dig through the logs).

Attachments

Change History

03/14/13 17:53:56 changed by anonymous

  • status changed from new to closed.
  • resolution set to fixed.

(In [12718]) Patched for the typo.

03/24/13 06:35:24 changed by rjollos

  • description changed.

Add/Change #10666 (Error logging typo)




Change Properties
Action