Opened 6 months ago
Closed 4 months ago
#10694 closed enhancement (fixed)
Disable the Apply changes button until changes have been made
| Reported by: | rjollos | Owned by: | rjollos |
|---|---|---|---|
| Priority: | normal | Component: | AdminEnumListPlugin |
| Severity: | normal | Keywords: | |
| Cc: | nonplus, jun66j5 | Trac Release: |
Description (last modified by rjollos)
Disable the Apply changes button until one of the following events has occurred:
- One of the default radio buttons has been selected.
- The list has unsaved changes.
Attachments (0)
Change History (4)
comment:1 Changed 6 months ago by rjollos
- Description modified (diff)
- Status changed from new to assigned
- Summary changed from Disable the Save changes button until changes have been made to Disable the Apply changes button until changes have been made
comment:2 Changed 6 months ago by rjollos
comment:3 Changed 6 months ago by rjollos
In [12437] I have 3 instances of $('#enumtable div input[name="apply"]'). Do you think it is worth extract this into a variable? I don't see any performance issues here, but I've read recommendations that repeated execution of a selector should be avoided when possibly for performance reasons. I'm primarily concerned that this could reduce code clarity. I could equally see it as improving code clarity though.
Another recommendation I've read, but have yet to see in any jquery code, is that variables that contain selectors should be named starting with $. For example, $apply = $('#enumtable div input[name="apply"]'). Is that variable naming pattern commonly used?
comment:4 Changed 4 months ago by rjollos
- Resolution set to fixed
- Status changed from assigned to closed


(In [12437]) Refs #10694: Apply changes button is disabled until a change has been made.