Modify

Opened 22 months ago

Closed 20 months ago

Last modified 18 months ago

#10808 closed defect (fixed)

Version 0.11 using to_utimestamp instead of to_timestamp

Reported by: binnut_@… Owned by: ChrisNelson
Priority: normal Component: TracJsGanttPlugin
Severity: major Keywords: loading to_utimestamp
Cc: Trac Release: 0.11

Description (last modified by rjollos)

The plugin wont load for me, i get the following message

Trac[loader] ERROR: Skipping "tracjsgantt = tracjsgantt": (can't import "ImportError: cannot import name to_utimestamp")

After some research i have found that it is because 0.12 uses to_utimestamp but 0.11 uses to_timestamp.

It seams that this plugin have been changed to match 0.12 in the 0.11 version, but that have introduced this loading bug.

Attachments (1)

patch10808.patch (635 bytes) - added by ChrisNelson 22 months ago.
Patch that may fix to_utimestamp() import issue.

Download all attachments as: .zip

Change History (12)

comment:1 follow-up: Changed 22 months ago by ChrisNelson

  • Summary changed from [Bug] version 0.11 using to_utimestamp instead of to_timestamp to Version 0.11 using to_utimestamp instead of to_timestamp

I develop and use the plugin in 0.11.6. There should be code in the plugin to make to_utimestamp() work.

What version of Trac are you using?

comment:2 follow-up: Changed 22 months ago by rjollos

  • Description modified (diff)

comment:3 in reply to: ↑ 1 ; follow-up: Changed 22 months ago by rjollos

Replying to ChrisNelson:

I develop and use the plugin in 0.11.6. There should be code in the plugin to make to_utimestamp() work.

I had thought the same, but all I see is the following:

from trac.util.datefmt import to_utimestamp, localtz

If I remember correctly you have a patched version of Trac 0.11.x that uses utimestamps. Wasn't there some code such as the following implemented in the plugin at some point?:

try:
    from trac.util.datefmt import to_utimestamp
except ImportError:
    from trac.util.datefmt import to_timestamp as to_utimestamp

comment:4 follow-up: Changed 22 months ago by rjollos

Maybe this is the offending changeset?

comment:5 in reply to: ↑ 2 Changed 22 months ago by binnut_@…

Replying to rjollos: I'm using version 0.11.7.

comment:6 in reply to: ↑ 4 Changed 22 months ago by ChrisNelson

  • Status changed from new to assigned

Replying to rjollos:

Maybe this is the offending changeset?

That seems very likely. Thanks for the pointer!

comment:7 in reply to: ↑ 3 Changed 22 months ago by ChrisNelson

Replying to rjollos:

Replying to ChrisNelson:

I develop and use the plugin in 0.11.6. There should be code in the plugin to make to_utimestamp() work.

I had thought the same, but all I see is the following:

from trac.util.datefmt import to_utimestamp, localtz

If I remember correctly you have a patched version of Trac 0.11.x that uses utimestamps. Wasn't there some code such as the following implemented in the plugin at some point?:

try:
    from trac.util.datefmt import to_utimestamp
except ImportError:
    from trac.util.datefmt import to_timestamp as to_utimestamp

That sounds really familiar but I can't find it anywhere on any branch in my repository.

comment:8 Changed 22 months ago by ChrisNelson

I can't push to T-H right now (some authentication failure) but I'll attach a patch that I hope will help.

Changed 22 months ago by ChrisNelson

Patch that may fix to_utimestamp() import issue.

comment:9 Changed 22 months ago by ChrisNelson

(In [12565]) to_utimestamp isn't in 0.11. Refs #10808.

comment:10 Changed 20 months ago by ChrisNelson

  • Resolution set to fixed
  • Status changed from assigned to closed

Seems to be working.

comment:11 Changed 18 months ago by rjollos

This issue had previously been reported in comment:4:ticket:10405 as well.

Add Comment

Modify Ticket

Action
as closed The owner will remain ChrisNelson.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.