Modify

Opened 18 months ago

Closed 11 months ago

Last modified 10 months ago

#11118 closed defect (fixed)

Update button on the Query page can be hidden by hide rules

Reported by: rjollos Owned by: rjollos
Priority: normal Component: DynamicFieldsPlugin
Severity: normal Keywords: pull-request
Cc: Trac Release:

Description

As discussed on the mailing list, the hide rule that is applied to Priority will also hide the div enclosing the Update button on the Query page.

This is because the selector input[value="priority"] will also capture the hidden input element,

<div class="buttons">
          <input type="hidden" name="order" value="priority">
          <input type="submit" name="update" value="Update">
</div> 

and its parent that also encloses the Update button will be hidden.

Attachments (0)

Change History (8)

comment:1 Changed 18 months ago by rjollos

Patch in 3e2f3e11. I tested with Trac 0.11.0 and Trac 1.0.2dev. As far as pushing the change goes, same request as in comment:3:ticket:10476. Thank you for your time and review of the changes.

comment:2 Changed 18 months ago by rjollos

  • Keywords pull-request added

comment:3 Changed 16 months ago by rjollos

Rob, have you had a chance to look at the changeset, and any thoughts on whether you'd be okay with me publishing these changes to the trac-hacks repository?

comment:4 Changed 11 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

In 13536:

Fixes #11118: Use a more precise selector for hiding the select and option elements on the Query page to avoid also applying the hide method to the parent of the hidden input element with value = priority when a hide rule applies to the ticket's Priority.

comment:5 Changed 11 months ago by rjollos

  • Owner changed from robguttman to rjollos

comment:6 Changed 11 months ago by robguttman

Ryan, thanks so much for your help! Feel free to help maintain any of my plugins at anytime.

comment:7 Changed 11 months ago by rjollos

Thanks Rob! I look forward to contributing more.

If you find a moment, would you mind taking a look at #10476 and let me know what you think? I'm mainly trying to understand the motivation for the initial change to case-sensitive options (comment:4:ticket:10476).

comment:8 Changed 10 months ago by rjollos

In 13650:

Bump version to 1.2.4. Refs #11378, #11118, #11523, #10126, #9605, #9986, #9996, #8971.

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.