Modify

Opened 12 months ago

Closed 11 months ago

Last modified 11 months ago

#11414 closed defect (fixed)

Tickets by resolution displays incorrect data

Reported by: araderma Owned by: rjollos
Priority: low Component: TracMetrixPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.12

Description

The Tickets by Resolution displays incorrect data. It will always display all tickets as resolved by as a single status (e.g. 'fixed', 'worksforme', etc.) based on the resolution status of the last ticket that has been resolved.

The problem can be fixed by adding 'GROUP BY resolution' to the end of the query starting on line 85 in model.py so the query looks like this:

            cursor.execute("""
                SELECT resolution, count(resolution) FROM ticket
                WHERE status='closed' AND id IN (%s) GROUP BY resolution""" 
                % ",".join(str_ids))

Attachments (0)

Change History (7)

comment:1 Changed 11 months ago by rjollos

  • Status changed from new to accepted

comment:2 Changed 11 months ago by rjollos

In 13558:

Group tickets by resolution. Untested change. Refs #11414.

Patch by araderma.

comment:3 follow-up: Changed 11 months ago by rjollos

  • Resolution set to fixed
  • Status changed from accepted to closed

I haven't had any time for this plugin in a while. I appreciate if you are able to test the changes that were committed and report back how it is working.

comment:4 in reply to: ↑ 3 ; follow-up: Changed 11 months ago by araderma

Replying to rjollos:

I haven't had any time for this plugin in a while. I appreciate if you are able to test the changes that were committed and report back how it is working.

I'll do that. I noticed that there were some other issues as well, so I've slowly been working on a lot of various fixes and decided that rather than making a lot of individual reports it would probably just be better to roll it into one big patch.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 11 months ago by rjollos

Replying to araderma:

I'll do that. I noticed that there were some other issues as well, so I've slowly been working on a lot of various fixes and decided that rather than making a lot of individual reports it would probably just be better to roll it into one big patch.

I don't mind if you report everything in one ticket, but the smaller patches are easier to review and test. With a big patch I'll end up spending time breaking it up (git add -p).

comment:6 in reply to: ↑ 5 Changed 11 months ago by araderma

Replying to rjollos:

I don't mind if you report everything in one ticket, but the smaller patches are easier to review and test. With a big patch I'll end up spending time breaking it up (git add -p).

I can break it up into different components then and just report it in one ticket once I've finished.

comment:7 Changed 11 months ago by rjollos

If you post just a few small patches and the changes look good, I'll be happy to give you commit access.

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.