Modify

Opened 9 months ago

Closed 9 months ago

Last modified 5 months ago

#11435 closed defect (fixed)

Make tag provider signature conform to interface definition

Reported by: hasienda Owned by: osimons
Priority: normal Component: FullBlogPlugin
Severity: normal Keywords: provider
Cc: rjollos Trac Release: 0.11

Description

As reported in #11434 tag providers did not strictly conform to the interface definition (see ITagProvider class definition in tractags/api.py).

While one might argue, that issues could be prevented by defensive programming, I'd prefer to fix it. Here is the small change required for this plugin. Thanks for taking care in advance.

Attachments (1)

20131208_fix_tag-provider.patch (464 bytes) - added by hasienda 9 months ago.
proposed fix for FullBlogTagSystem.get_tagged_resources

Download all attachments as: .zip

Change History (3)

Changed 9 months ago by hasienda

proposed fix for FullBlogTagSystem.get_tagged_resources

comment:1 Changed 9 months ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

In 13462:

FullBlogPlugin: Conform to latest version of Tags API. Closes #11435.

comment:2 Changed 5 months ago by hasienda

In 13802:

TagsPlugin: Log ITagProvider issue as warning, refs #11435 and #11658.

Since [13427] TagSystem.get_all_tags() requires stricter API conformance
of ITagProvider implementations regarding its get_tagged_resources method.
Own implementations have been fixed in [13461], but we keep the extra
'try-catch' from [13799-13800] for easier detection of the same issue with
other ITagProviders, namely versions of FullBlogPlugin before r13462.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.