Unexpected keyword argument to TracError.__init__

[Ryan J Ollos]

I've been reviewing the code for possible inclusion in the Trac core, and spotted the following issue:

customfieldadminplugin/0.11/customfieldadmin/api.py

@@ -106 +106 @@
         # Check that it is a valid field type
         if not cfield['type'] in \
                         ['text', 'checkbox', 'select', 'radio', 'textarea']:
-            raise TracError(_("%(field_type)s is not a valid field type"),
-                                        field_type=cfield['type'])
+            raise TracError(_("%(field_type)s is not a valid field type",
+                              field_type=cfield['type']))
         # Check that field does not already exist
         # (if modify it should already be deleted)
         if create and self.config.get('ticket-custom', cfield['name']):

It's unlikely to cause any issues as far as I can see since there are other checks in place, but if the TracError was raised, the following traceback would result:

Traceback (most recent call last):
  File "/home/user/Workspace/th11536/teo-rjollos.git/trac/web/main.py", line 506, in _dispatch_request
    dispatcher.dispatch(req)
  File "/home/user/Workspace/th11536/teo-rjollos.git/trac/web/main.py", line 221, in dispatch
    resp = chosen_handler.process_request(req)
  File "/home/user/Workspace/th11536/teo-rjollos.git/trac/admin/web_ui.py", line 125, in process_request
    path_info)
  File "/home/user/Workspace/trachacks.git/customfieldadminplugin/0.11/customfieldadmin/admin.py", line 87, in render_admin_panel
    cf_api.update_custom_field(cfield, create=True)
  File "/home/user/Workspace/trachacks.git/customfieldadminplugin/0.11/customfieldadmin/api.py", line 158, in update_custom_field
    self.verify_custom_field(cfield)
  File "/home/user/Workspace/trachacks.git/customfieldadminplugin/0.11/customfieldadmin/api.py", line 110, in verify_custom_field
    field_type=cfield['type'])
TypeError: __init__() got an unexpected keyword argument 'field_type'

[osimons]

In 13638:

CustomFieldAdminPlugin: Typo in i18n error message call. Closes #11538.

Well spotted, rjollos ;-)

[Ryan J Ollos]

Replying to rjollos:

I've been reviewing the code for possible inclusion in the Trac core, ...

I think this can be done in 20-30 hours effort, so I'm going to push it for ​milestone:1.1.3: ​trac:#11469.