Modify

Opened 3 years ago

Closed 3 years ago

#13930 closed enhancement (fixed)

CSS style class

Reported by: clemens Owned by: Ryan J Ollos
Priority: normal Component: SearchAllPlugin
Severity: normal Keywords: patch
Cc: Trac Release:

Description (last modified by clemens)

The purpose of the SearchAllPlugin is to provide search results for external Trac projects additionally to local ones. In order to be able to distinguish external vs. local search results I am proposing a CSS class for the all search results yielded by SearchAllPlugin.

Here is my proposed patch: attachment:searchall.py.diff.
It will create a <span> with a dedicated CSS class around the name of the external project.

  • Original
    original screenshot
  • Patch (with frame around project)
    screenshot after patch - Note that the style is just an example. What we need is the CSS class.

The CSS could be integrated in the plugin itself. This way the new visual markup would be available out of the box. (However, I do not know how to do this). Another option is to put the CSS in a local customized style.css. In any case we will need the new CSS class.

The actual CSS style is a matter of taste. Here is just an example which put a frame around the external projects.

#content.search #results .searchall_project
{
 border: 1pt solid;
 padding: 0 .2em 0 .2em;
}

The primary intention of this ticket is to have the CSS class in the HTML which is generated by the plugin. The particular style is secondary.

Attachments (3)

searchall.py.diff (573 bytes) - added by clemens 3 years ago.
patch file adding a CSS class
2021-01-01-tracsearchall-r16957.png (83.0 KB) - added by clemens 3 years ago.
original screenshot
2021-01-01-tracsearchall-new.png (82.8 KB) - added by clemens 3 years ago.
screenshot after patch - Note that the style is just an example. What we need is the CSS class.

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by clemens

Attachment: searchall.py.diff added

patch file adding a CSS class

Changed 3 years ago by clemens

original screenshot

Changed 3 years ago by clemens

screenshot after patch - Note that the style is just an example. What we need is the CSS class.

comment:1 Changed 3 years ago by clemens

Description: modified (diff)

comment:2 Changed 3 years ago by figaro

Keywords: patch added

comment:3 Changed 3 years ago by Ryan J Ollos

Owner: changed from Álvaro Iradier to Ryan J Ollos
Status: newaccepted

comment:4 Changed 3 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 18446:

TracSearchAll 0.9: Wrap search results in a span

Fixes #13930.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.