Modify

Opened 7 years ago

Closed 7 years ago

#1747 closed enhancement (fixed)

patch - displays the number of comments for each file in a review's file list

Reported by: tvolpini@… Owned by: mikechml
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

  • codereview/templates/peerReviewView.cs

     
    5858            <td>Filename</td>
    5959            <td>Revision</td>
    6060            <td>Line Numbers</td>
     61            <td># of Comments</td>
    6162        </tr>
    6263    </thead>
    6364    <tbody>
     
    7273                    <td><a href="<?cs var:trac.href.peerReviewPerform ?>?IDFile=<?cs var:item[0]?>"><?cs var:item[2]?></a></td>
    7374                    <td><a href="<?cs var:trac.href.peerReviewPerform ?>?IDFile=<?cs var:item[0]?>"><?cs var:item[5]?></a></td>
    7475                    <td><a href="<?cs var:trac.href.peerReviewPerform ?>?IDFile=<?cs var:item[0]?>"><?cs var:item[3]?>-<?cs var:item[4]?></a></td>
     76                    <td><a href="<?cs var:trac.href.peerReviewPerform ?>?IDFile=<?cs var:item[0]?>"><?cs var:item[6]?></a></td>
    7577                </tr>
    7678            <?cs /each ?>
    7779        <?cs /if ?>
  • codereview/peerReviewView.py

     
    8181            newfile.append(struct.LineStart)
    8282            newfile.append(struct.LineEnd)
    8383            newfile.append(struct.Version)
     84            newfile.append(len(dbBack.getCommentsByFileID(struct.IDFile)))
    8485            returnfiles.append(newfile)
    8586            newfile = []
    8687        req.hdf['files'] = returnfiles

Attachments (0)

Change History (1)

comment:1 Changed 7 years ago by djeebus

  • Resolution set to fixed
  • Status changed from new to closed

(In [2578]) Check ChangeLog. Fixes #1747

Add Comment

Modify Ticket

Action
as closed The owner will remain mikechml.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.