Modify

Opened 7 years ago

Closed 7 years ago

#1784 closed enhancement (fixed)

[patch] Various improvements to TOC macro for 0.11

Reported by: osimons Owned by: coderanger
Priority: normal Component: TocMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Enclosed is a patch that:

  • Accepts wildcard (ike 'Trac*') as input for pagename (will close #480).
  • Respects notitle argument also for titleindex only making it a list of the page names.
  • For empty pages and titleindex, it will add all pages instead of just the current page (a much more useful title index...)
  • Changes default heading to 'Page Index' if it is a titleindex being rendered (and it is not replaced by another heading as argument, or noheading is passed).
  • Properly highlights the current page if it exists in a title index list.
  • Does some updates to resolve the various FIXME: and TODO: items in the code.
  • Updates documentation to reflect these changes, and also removes a piece information that has not been true for some time.

As far as I can tell, these changes are all very gentle with regards to existing uses of the macro - I don't think they will be affected negatively.

Attachments (2)

tocmacro_various_011dev-r2460.diff (6.6 KB) - added by osimons 7 years ago.
Patch for r2460 - various improvements to TOC macro.
tocmacro_various_011dev-r2794.diff (9.7 KB) - added by osimons 7 years ago.
Patch updated for new resource / context APIs + supporting new fine-grained security + reviewed all code again.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by osimons

Patch for r2460 - various improvements to TOC macro.

comment:1 Changed 7 years ago by osimons

  • Summary changed from [path] Various improvements to TOC macro for 0.11 to [patch] Various improvements to TOC macro for 0.11

Oops. Typo in title. Updated.

Changed 7 years ago by osimons

Patch updated for new resource / context APIs + supporting new fine-grained security + reviewed all code again.

comment:2 Changed 7 years ago by osimons

(In [2801]) TocMacro: Various improvements + support for latest 0.11dev with context refactoring + fine-grained permissions.

For details see #1784 - some highlights:

  • Wildcard support on page names
  • titleindex for no pages will return all pages
  • and, see ticket for more...

comment:3 Changed 7 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

Commit done. Ticket closed.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.