Modify

Opened 7 years ago

Closed 3 years ago

#2032 closed defect (worksforme)

[Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin

Reported by: spike@… Owned by: rjollos
Priority: normal Component: SimpleTicketPlugin
Severity: minor Keywords:
Cc: rjollos, falkb Trac Release: 0.10

Description (last modified by rjollos)

Using PrivateTicketPlugin and giving users one of the added permissions instead of TICKET_VIEW causes a problem in redirect():

     def redirect(self, dest):
        if dest.startswith(self.env.href.ticket()):
            if not (self.req.perm.has_permission('TICKET_VIEW'):
                self.req.redirect(self.env.href.simpleticket())

TICKET_VIEW_REPORTER and TICKET_VIEW_SELF are the only ones to be added because the other permissions do not concern the creation of ticket.

Patch attached.

Attachments (1)

simpleticket.patch (604 bytes) - added by spike@… 7 years ago.
Patch file

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by spike@…

Patch file

comment:1 Changed 7 years ago by coderanger

Simply hard coding those in is not a terribly good solution to me. Using the new security stuff in 0.11 (once PrivateTickets is ported) this should be much cleaner.

comment:2 Changed 5 years ago by rjollos

  • Cc rjollos added

comment:3 Changed 5 years ago by anonymous

  • Summary changed from SimpleTicketPlugin not playing well with PrivateTicketPlugin to [Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin

comment:4 Changed 3 years ago by rjollos

  • Cc falkb added
  • Owner changed from coderanger to rjollos
  • Status changed from new to assigned

I'll be testing r10990 with the PrivateTicketsPlugin to see if there are any outstanding issues still.

comment:5 Changed 3 years ago by rjollos

  • Description modified (diff)
  • Resolution set to worksforme
  • Status changed from assigned to closed

I've tested with Trac 0.12.2 and SimpleTicketPlugin is working well with PrivateTicketsPlugin. There is no reference to the TICKET_VIEW in the 0.11 version of SimpleTicketPlugin.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.