Ticket #2032 (closed defect: worksforme)

Opened 4 years ago

Last modified 2 months ago

[Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin

Reported by: spike@fatdrop.co.uk Assigned to: rjollos
Priority: normal Component: SimpleTicketPlugin
Severity: minor Keywords:
Cc: rjollos, falkb Trac Release: 0.10

Description (Last modified by rjollos)

Using PrivateTicketPlugin and giving users one of the added permissions instead of TICKET_VIEW causes a problem in redirect(): 

     def redirect(self, dest):
        if dest.startswith(self.env.href.ticket()):
            if not (self.req.perm.has_permission('TICKET_VIEW'):
                self.req.redirect(self.env.href.simpleticket())

TICKET_VIEW_REPORTER and TICKET_VIEW_SELF are the only ones to be added because the other permissions do not concern the creation of ticket.

Patch attached.

Attachments

simpleticket.patch (0.6 kB) - added by spike@fatdrop.co.uk on 09/11/07 03:09:53.
Patch file

Change History

09/11/07 03:09:53 changed by spike@fatdrop.co.uk

  • attachment simpleticket.patch added.

Patch file

09/11/07 03:59:07 changed by coderanger

Simply hard coding those in is not a terribly good solution to me. Using the new security stuff in 0.11 (once PrivateTickets is ported) this should be much cleaner.

08/11/09 23:17:03 changed by rjollos

  • cc set to rjollos.

10/28/09 00:47:24 changed by anonymous

  • summary changed from SimpleTicketPlugin not playing well with PrivateTicketPlugin to [Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin.

12/02/11 10:08:23 changed by rjollos

  • cc changed from rjollos to rjollos, falkb.
  • owner changed from coderanger to rjollos.
  • status changed from new to assigned.

I'll be testing r10990 with the PrivateTicketsPlugin to see if there are any outstanding issues still.

12/03/11 02:04:16 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to worksforme.
  • description changed.

I've tested with Trac 0.12.2 and SimpleTicketPlugin is working well with PrivateTicketsPlugin. There is no reference to the TICKET_VIEW in the 0.11 version of SimpleTicketPlugin.

Add/Change #2032 ([Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin)




Change Properties
Action