Modify

Opened 6 years ago

Closed 4 years ago

#2143 closed defect (fixed)

[Patch] Indexer _strip wrong regexp (non-ascii char issue)

Reported by: slach@… Owned by: rjollos
Priority: normal Component: RepoSearchPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

indexer.py line 193

_strip = re.compile(r'\w+')

must be replace
_strip = re.compile('[\w_]+',re.U)

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by athomas

  • Resolution set to invalid
  • Status changed from new to closed

_ is already included by \w.

comment:2 Changed 6 years ago by anonymous

  • Resolution invalid deleted
  • Status changed from closed to reopened

when not using re.U, non-ascii character not indexed

comment:3 Changed 4 years ago by rjollos

Reassigning ticket after changing maintainer of plugin.

comment:4 Changed 4 years ago by rjollos

  • Owner changed from athomas to rjollos
  • Status changed from reopened to new

comment:5 Changed 4 years ago by rjollos

  • Summary changed from Indexer _strip wrong regexp to Indexer _strip wrong regexp (non-ascii char issue)

There seem to be numerous reports related to us of non-ascii characters. I will test out your fix, but could really use someone to test on their non-english installation.

comment:6 Changed 4 years ago by rjollos

  • Summary changed from Indexer _strip wrong regexp (non-ascii char issue) to [Patch] Indexer _strip wrong regexp (non-ascii char issue)

comment:7 Changed 4 years ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [8523]) Fixed problem with indexing non-ascii characters. Fixes #2143.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.