Opened 6 years ago

Closed 6 years ago

#2222 closed enhancement (fixed)

Description

This feature is used on http://oss.euedge.com, because the various source based distributions (MacPorts, Gentoo Portage) require specific naming conventions for the download links + it is nice to have the filename in the link (in our opinion) .

Could you please apply this patch? It is completely non-intrusive, can be switched on and off with graceful degradation: that is if the filenames are not unique it is undeterministic which file will be downloaded. The feature is off by default.

The patch can be applied with:

cd 0.10
patch -p6 .../dlbyname.diff


comment:1 Changed 6 years ago by Blackhex

• Priority changed from normal to high
• Severity changed from normal to minor
• Status changed from new to assigned
• Summary changed from Patch: Optionally use the filenames as key for download items to RFE: Optionally use the filenames as key for download items

Thanks for your patch. I'll apply it together with port to 0.11 which I've recieved today. This may take a week or two since I'm too busy to do that right now.

comment:2 Changed 6 years ago by Blackhex

• Resolution set to fixed
• Status changed from assigned to closed

I applied you patch to 0.11 branch with few modificatoins. Main difference is filename_key option renamed to unique_filename. I don't want to append new features to 0.10 branch since 0.11 is develpped so if you really want this in 0.10, let me know.

Modify Ticket

Change Properties