Modify

Opened 6 years ago

Last modified 5 months ago

#2404 assigned enhancement

Ability to tag a changeset

Reported by: anonymous Owned by: athomas
Priority: normal Component: TagsPlugin
Severity: normal Keywords: changeset repository DefaultTagProvider
Cc: itamarost@…, rjollos, otaku42, osimons Trac Release: 0.10

Description

For the tags plugin(s) I'd like the ability to tag a changeset (currently it only supports wiki and tickets).

E.g. tag a changeset that deals with a certain target platform, feature, etc.

I would post this to the Tags trac but it's full of spam!

Attachments (0)

Change History (6)

comment:1 Changed 6 years ago by athomas

  • Status changed from new to assigned

This would be useful.

comment:2 follow-up: Changed 6 years ago by nat at ilike dash inc dot com

tagging a changeset would be great, but since i'm not sure where that would hang in the schema i would also be happy with just having a changeset tagspace based on title,author and time-range support in ListTagged so I could pull up e.g. important changesets in the current milestone:

[[ListTagged(expression="+REVIEW+(time>2008/02/01)+(time<2008/02/08)", tagspace=changesets)]

yeah, this is sort of a bastardization of the query language and tags, but time ranges are pretty important for tickets & changesets, ranges would be great to have in ListTagged.

comment:3 Changed 5 years ago by rjollos

  • Cc rjollos added
  • Summary changed from ability to tag a changeset to Ability to tag a changeset

See also Ticket #2428.

comment:4 in reply to: ↑ description Changed 4 years ago by hasienda

  • Keywords changeset repository DefaultTagProvider added

Replying to anonymous:

For the tags plugin(s) I'd like the ability to tag a changeset (currently it only supports wiki and tickets).

Sorry, but this is simply not true (see: http://trac-hacks.org/browser/screenshotsplugin/0.11/tracscreenshots/tags.py). So you just would need to create a new ChangesetTagProvider(DefaultTagProvider) to integrate such an additional realm into TagsSystem. I've done testing of http://trac-hacks.org/wiki/ScreenshotsPlugin, and it works great with that realm 'screenshots'.

E.g. tag a changeset that deals with a certain target platform, feature, etc.

Of course this could be useful.

I would post this to the Tags trac but it's full of spam!

? I know both, t-h.o and t.e.o, and think this is not valid, so what Trac other than do you refer to here?

comment:5 in reply to: ↑ 2 Changed 3 years ago by hasienda

  • Cc itamarost@… otaku42 osimons added

Replying to nat at ilike dash inc dot com:

tagging a changeset would be great, but since i'm not sure where that would hang in the schema i would also be happy with just having a changeset tagspace based on title,author and time-range support in ListTagged so I could pull up e.g. important changesets in the current milestone:
![...]
yeah, this is sort of a bastardization of the query language and tags, but time ranges are pretty important for tickets & changesets, ranges would be great to have in ListTagged.

You name it. Additional tagged resource properties are not included by any tag provider into the tag data domain. What you ask for here is more or less a request, that must be fulfilled by a query inside repositories, that should be aware of the TagsPlugin, query it and re-use it's data. IIRC FullBlogPlugin and ScreenshotsPlugin are good examples for implementations of tagging into realms other than 'ticket'.

'Wiki' is not. A request similar to this one here is #2429 for the 'wiki' realm - both connected by the absence of a distinct keywords/tags attribute/field. I feel a strong distraction, to do something like that inside the TagsPlugin. It would be monkey-patching the other realms data storage. Better add it there directly. And never try to bring additional resource data into the tag realm. Keeping data inside the resulting db schema consistent would be a real mess.

comment:6 Changed 5 months ago by hasienda

As a matter of fact we made it happen for 'wiki' tag realm with a new request proxy, that enables exactly that complementary data storage and consistent changes. So the hurdle has been lowered significantly at least.

Add Comment

Modify Ticket

Action
as assigned .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.