Modify

Opened 6 years ago

Closed 6 years ago

#3008 closed defect (fixed)

Method previous_rev() with 3 arguments

Reported by: marble Owned by: hvr
Priority: normal Component: GitPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

In order to make work properly Git with Trac and avoid an error when visualizing changesets, I have had to change file 'gitplugin/0.11/tracext/git/git_fs.py', and add a third argument:

line 252: def previous_rev(self, rev, path=):

It seems like Trac calls previous_rev() with 3 arguments when GitPlugin's original method has 2 arguments.

Attachments (1)

gitplugin-prevrev.patch (419 bytes) - added by zany 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by zany

comment:1 Changed 6 years ago by anonymous

+1. works lika a charm

Trac: 0.11
Python: 2.5.2 (r252:60911, Apr 21 2008, 11:17:30) [GCC 4.2.3 (Ubuntu 4.2.3-2ubuntu7)]
setuptools: 0.6c8
pyPgSQL: 2.5.1
Genshi: 0.5.1
GIT: 1.5.4.3
jQuery: 1.2.3

comment:2 Changed 6 years ago by hvr

  • Resolution set to fixed
  • Status changed from new to closed

(In [4147]) GitPlugin: add (ignored) path argument to previous_rev method (fixes #3008)

comment:3 Changed 6 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 Changed 6 years ago by anonymous

  • Resolution set to fixed
  • Status changed from reopened to closed

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hvr. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.