Modify

Opened 6 years ago

Closed 2 years ago

#3338 closed task (duplicate)

[Patch] Changes for trac 0.11

Reported by: echo0101 Owned by: peca
Priority: normal Component: TracDownloaderPlugin
Severity: critical Keywords:
Cc: Trac Release: 0.11

Description

revision 3973 is incompatible with trac 0.11. self.env.href should be changed to req.href

prentice@dev:~/TracDownloader-svn/0.11/tracdownloader$ svn diff web_ui.py
Index: web_ui.py
===================================================================
--- web_ui.py	(revision 3973)
+++ web_ui.py	(working copy)
@@ -49,8 +49,7 @@
     def get_navigation_items(self, req):
         """Downloader isinstance visible if user hasattr got permission """
         if req.perm.has_permission('DOWNLOADER_DOWNLOAD'):
-            yield 'mainnav', 'downloader', Markup('<a href="%s">Downloader</a>',
-                                             self.env.href.downloader())
+            yield 'mainnav', 'downloader', Markup('<a href="%s">Downloader</a>') % req.href.downloader()
 
     # IRequestHandler methods

see http://trac.edgewall.org/wiki/TracDev/ApiChanges/0.10

Attachments (0)

Change History (2)

comment:1 Changed 3 years ago by rjollos

  • Summary changed from changes for trac 0.11 to [Patch] Changes for trac 0.11

comment:2 Changed 2 years ago by rjollos

  • Resolution set to duplicate
  • Status changed from new to closed

Fixed on the 0.11 branch in #5540.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from peca. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.