Modify

Opened 6 years ago

Last modified 6 years ago

#3382 new defect

[PATCH] Multiple fixes

Reported by: jamesyonan Owned by: permon
Priority: normal Component: MediaWikiPluginMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

This patch is against http://trac-hacks.org/svn/mediawikipluginmacro (r2483)

  • Fixed issue where _specialUrlPat regex in replaceFreeExternalLinks was failing to render external links in paragraphs containing newlines because the re.DOTALL regex flag was not being used to allow .* to match newlines.
  • Fixed bug in replaceFreeExternalLinks where the loop variable 'i' was being stepped on for another purpose by code inside the loop.
  • Fixed regex issue where control-char ranges for ascii were being specified to match against unicode strings.
  • Fixed issue where nextItem was called with only one rather than the required two parameters.
  • Support rendering of anchor links such as: [[#heading 4|heading four]]

Attachments (1)

mediawikipluginmacro.diff (5.2 KB) - added by jamesyonan 6 years ago.

Download all attachments as: .zip

Change History (2)

Changed 6 years ago by jamesyonan

comment:1 Changed 6 years ago by dclark@…

Thanks - without this patch, this plugin doesn't work in trac 0.11; with it, it does.

If you install system-wide you'll also need this in your trac.ini [components] section:

mediawiki.* = enabled

Debian package with this patch (built on Ubuntu Hardy): http://config.fsf.org/packages/pool/ubuntu-hardy/custom/tracmediawikimacro_1.0-2_all.deb

Add Comment

Modify Ticket

Action
as new The owner will remain permon.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.