Modify

Opened 8 years ago

Closed 8 years ago

#357 closed defect (fixed)

Invalid link href

Reported by: gotoh Owned by: pacopablo
Priority: normal Component: TracBlogPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

blog.cs uses invalid href starts with href="/tags/..." and href="/wiki/..."
and it navigates to out of trac project.
There's a patch to use cgi_location and trac.href.wiki to fix this issue against r753.

  • 0.10/blog/templates/blog.cs

     
    4040        <div class="postmeta"> 
    4141            <ul> 
    4242                <?cs if bentry.tags.present != 0 ?> 
    43                 <li>Posted in: <?cs each:tag=bentry.tags.tags ?><a href="/tags/<?cs var:tag.link ?>"><?cs var:tag.name ?></a><?cs if ! tag.last ?>,<?cs /if ?> <?cs /each ?> <?cs if bentry.tags.more ?><a href="/wiki/<?cs var:bentry.name ?>">...</a><?cs /if ?> 
     43                <li>Posted in: <?cs each:tag=bentry.tags.tags ?><a href="<?cs var:cgi_location ?>/tags/<?cs var:tag.link ?>"><?cs var:tag.name ?></a><?cs if ! tag.last ?>,<?cs /if ?> <?cs /each ?> <?cs if bentry.tags.more ?><a href="<?cs var:trac.href.wiki ?>/<?cs var:bentry.name ?>">...</a><?cs /if ?> 
    4444                <?cs /if ?> 
    4545                <li><?cs var:bentry.wiki_link ?></li> 
    4646                <li><?cs var:bentry.author ?></li> 

Attachments (0)

Change History (1)

comment:1 Changed 8 years ago by pacopablo

  • Resolution set to fixed
  • Status changed from new to closed

(In [755]) * Refactor repository layout such that I can more easily restructure the code without leaving it in a broken state

  • Apply patch from gotoh fixing invalid links. Closes #357. Thanks gotoh

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.