Modify

Opened 6 years ago

Closed 6 years ago

#3771 closed defect (fixed)

Switch from hardcoded HTML formatting to CSS for images

Reported by: izzy Owned by: Blackhex
Priority: normal Component: ScreenshotsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

The border attributes (and some others) are right now rendered as HTML attributes rather than CSS code - this makes it hard to override them by Stylesheets. E.g. the default value for the border attribute is "1", so if not explicitly specified otherwise, it will turn out as <img border="1" ...> in the page, which causes nasty red boxes around. Would be nice if that could be changed to <img style="border: 1px; ...> instead.

This is affecting Trac 0.10 *and* 0.11 versions.

Funny: On the 0.11 installation we tapped into that, it seems that only Screenshots affected when no align was explicitly defined...

Attachments (0)

Change History (5)

comment:1 Changed 6 years ago by Blackhex

  • Status changed from new to assigned

As I checked now, all borders are specified the second way (<img style="border: 1px; ...>). Could you sent me macro signature wich is generating borders as HTML attributes?

comment:2 Changed 6 years ago by Blackhex

What about this?

comment:3 Changed 6 years ago by Blackhex

OK, r4344 changes behavior of align=center}} attribute so that it displays image as a block element centered on the page and not as inline element in text flow. {{{align=left and align=right diplays image as floating elements on left resp. right side of page. If you can, try it in IE and if you are satisfied close this ticket, please.

comment:4 Changed 6 years ago by izzy

Well, that's a double problem: Guess it's only applied to the 0.11 branch (where I do not have Shell access, in that project I'm a "normal member" - my own Trac installation is still 0.10), as there came no new files on svn up on the 0.10 branch - and second, there is no IE for Linux (well, even if there were, I would not use it).

So it looks like I can not test it before you're done with the other RFEs and have ported them all to the 0.10 branch, sorry...

comment:5 Changed 6 years ago by Blackhex

  • Resolution set to fixed
  • Status changed from assigned to closed

This will stay only in 0.11 branch.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Blackhex. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.