Ticket #3771 (closed defect: fixed)

Opened 2 months ago

Last modified 2 months ago

Switch from hardcoded HTML formatting to CSS for images

Reported by: izzy Assigned to: Blackhex
Priority: normal Component: ScreenshotsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

The border attributes (and some others) are right now rendered as HTML attributes rather than CSS code - this makes it hard to override them by Stylesheets. E.g. the default value for the border attribute is "1", so if not explicitly specified otherwise, it will turn out as <img border="1" ...> in the page, which causes nasty red boxes around. Would be nice if that could be changed to <img style="border: 1px; ...> instead.

This is affecting Trac 0.10 *and* 0.11 versions.

Funny: On the 0.11 installation we tapped into that, it seems that only Screenshots affected when no align was explicitly defined...

Attachments

Change History

09/20/08 16:04:30 changed by Blackhex

  • status changed from new to assigned.

As I checked now, all borders are specified the second way (<img style="border: 1px; ...>). Could you sent me macro signature wich is generating borders as HTML attributes?

09/22/08 12:05:02 changed by Blackhex

What about this?

09/26/08 07:01:20 changed by Blackhex

OK, r4344 changes behavior of align=center}} attribute so that it displays image as a block element centered on the page and not as inline element in text flow. {{{align=left and align=right diplays image as floating elements on left resp. right side of page. If you can, try it in IE and if you are satisfied close this ticket, please.

09/26/08 09:03:30 changed by izzy

Well, that's a double problem: Guess it's only applied to the 0.11 branch (where I do not have Shell access, in that project I'm a "normal member" - my own Trac installation is still 0.10), as there came no new files on svn up on the 0.10 branch - and second, there is no IE for Linux (well, even if there were, I would not use it).

So it looks like I can not test it before you're done with the other RFEs and have ported them all to the 0.10 branch, sorry...

10/06/08 05:43:42 changed by Blackhex

  • status changed from assigned to closed.
  • resolution set to fixed.

This will stay only in 0.11 branch.

Add/Change #3771 (Switch from hardcoded HTML formatting to CSS for images)




Change Properties
Action