Ticket #3780 (closed enhancement: fixed)

Opened 2 months ago

Last modified 2 months ago

RFE: Add First/Last page links in Matrix view

Reported by: izzy Assigned to: Blackhex
Priority: normal Component: ScreenshotsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

When you are just on it, something small here: Right now, Matrix View just offers previous/next page links. With many screenshots in the collection, it's not that easy to get to the last page to find out the number of the screenshot just added. A link like "first"/"last" page would be very helpful. Optionally you also could add something like "goto page x" ;)

Thank you in advance!

Attachments

Change History

(follow-up: ↓ 2 ) 09/27/08 17:21:41 changed by Blackhex

  • status changed from new to assigned.

Implementation for 0.11 branch in r4355.

(in reply to: ↑ 1 ) 09/29/08 13:16:44 changed by anonymous

Replying to Blackhex:

Implementation for 0.11 branch in r4355.

I just tested this version and it gives me the error: 

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11.1-py2.5.egg/trac/web/main.py", line 423, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11.1-py2.5.egg/trac/web/main.py", line 197, in dispatch
    resp = chosen_handler.process_request(req)
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/core.py", line 138, in process_request
    template, content_type = self._do_actions(context, actions)
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/core.py", line 594, in _do_actions
    render_screenshots(context.req, self.data)
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/matrix_view.py", line 70, in render_screenshots
    data['matrix'] = self._build_matrix(index, data['screenshots'])
  File "build/bdist.freebsd-7.0-RELEASE-p2-i386/egg/tracscreenshots/matrix_view.py", line 96, in _build_matrix
    row.append(screenshots[index + I])
IndexError: list index out of range

I suspect there is a case that isn't being handled when there are no screenshots to show.

09/30/08 03:45:58 changed by Blackhex

Empty screenshots works fine for me. This would be probably caused by negative index. I've added additional check in r4359.

10/06/08 05:43:18 changed by Blackhex

  • status changed from assigned to closed.
  • resolution set to fixed.

This will stay only in 0.11 branch.

Add/Change #3780 (RFE: Add First/Last page links in Matrix view)




Change Properties
Action