Modify

Opened 6 years ago

Closed 4 years ago

#4167 closed defect (fixed)

[patch] Concurrent edits of tickets can overwrite changes to blocking / blocked_by fields

Reported by: dagvl Owned by: coderanger
Priority: normal Component: MasterTicketsPlugin
Severity: major Keywords: concurrency, dataloss
Cc: dale.miller@…, mmitar@…, lukecyca Trac Release: 0.11

Description (last modified by coderanger)

Steps to reproduce:

Given two ticket #1 and #2, open both in their own browser window.
Go to ticket #2, set blocking to 1 and save.
Go to ticket #1, add a comment and click save.
You will get the "blocked_by deleted" message.

Analysis:
The plugin does not update the changetime of tickets when it modifies them causing MVCC to fail to detect the change.

Solution:
Always update the changetime on ticket changes.

Attached patch implements this behaviour.

Attachments (1)

concurrent_fix.patch (785 bytes) - added by dagvl 6 years ago.
Patch to fix concurrent edits issue

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by dagvl

Patch to fix concurrent edits issue

comment:1 Changed 6 years ago by anonymous

  • Cc dale.miller@… added

Added address to cc field.

comment:2 Changed 4 years ago by anonymous

  • Cc mmitar@… added

comment:3 Changed 4 years ago by lukecyca

This patch works great. I've been using it heavily in production for >6 months.

comment:4 Changed 4 years ago by lukecyca

  • Cc lukecyca added

comment:5 Changed 4 years ago by coderanger

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed

Fix committed.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.