Ticket #4167 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

[patch] Concurrent edits of tickets can overwrite changes to blocking / blocked_by fields

Reported by: dagvl Assigned to: coderanger
Priority: normal Component: MasterTicketsPlugin
Severity: major Keywords: concurrency, dataloss
Cc: dale.miller@ngc.com, mmitar@gmail.com, lukecyca Trac Release: 0.11

Description (Last modified by coderanger)

Steps to reproduce:

Given two ticket #1 and #2, open both in their own browser window. Go to ticket #2, set blocking to 1 and save. Go to ticket #1, add a comment and click save. You will get the "blocked_by deleted" message.

Analysis: The plugin does not update the changetime of tickets when it modifies them causing MVCC to fail to detect the change.

Solution: Always update the changetime on ticket changes.

Attached patch implements this behaviour.

Attachments

concurrent_fix.patch (0.8 kB) - added by dagvl on 11/26/08 11:18:50.
Patch to fix concurrent edits issue

Change History

11/26/08 11:18:50 changed by dagvl

  • attachment concurrent_fix.patch added.

Patch to fix concurrent edits issue

01/28/09 18:59:55 changed by anonymous

  • cc set to dale.miller@ngc.com.

Added address to cc field.

04/14/10 23:58:10 changed by anonymous

  • cc changed from dale.miller@ngc.com to dale.miller@ngc.com, mmitar@gmail.com.

08/14/10 01:16:10 changed by lukecyca

This patch works great. I've been using it heavily in production for >6 months.

08/14/10 01:26:12 changed by lukecyca

  • cc changed from dale.miller@ngc.com, mmitar@gmail.com to dale.miller@ngc.com, mmitar@gmail.com, lukecyca.

01/29/11 22:54:08 changed by coderanger

  • status changed from new to closed.
  • resolution set to fixed.
  • description changed.

Fix committed.

Add/Change #4167 ([patch] Concurrent edits of tickets can overwrite changes to blocking / blocked_by fields)




Change Properties
Action