Ticket #4467 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

rss links for posts, forums & messages

Reported by: tkor@gmx.de Assigned to: Blackhex
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Hi,

I recently had the problem of trying to use discussionplugin on a project I didnt have much time for, so I was in a kind of hassle. anyhow, trac did not generate clickable links in rss feeds (they were basically just file:///trac_env/... links, because "http://my.host.here" got omitted at the beginning of the link).

This happened ONLY in RSS mode, and I fixed it with a stupid workaround by hardcoding (yeah I know, but wth I am really no trac expert) the host name into timeline.py. There just HAS to be a better option than hardcoding; I just could not figure out how to get the base_url from there, but other than that, it fixes the problem for ONE trac environment.

Attached bad patch. anybody: DO NOT USE. JUST LOOK AT IT.

Attachments

bad-bad-hardcoded-patch.diff (1.1 kB) - added by anonymous on 01/15/09 23:23:15.
a really evil patch that cries out for a better way to be done. somehow.
4467-rss-links-base_url.patch (1.1 kB) - added by anonymous on 01/16/09 04:38:06.
fixed to use base_url instead of hardcoded path.

Change History

01/15/09 23:23:15 changed by anonymous

  • attachment bad-bad-hardcoded-patch.diff added.

a really evil patch that cries out for a better way to be done. somehow.

01/16/09 04:36:41 changed by tkor@gmx.de

okay, it was very easy.

will attach patch to fix it for good.

01/16/09 04:38:06 changed by anonymous

  • attachment 4467-rss-links-base_url.patch added.

fixed to use base_url instead of hardcoded path.

01/26/09 16:47:55 changed by Blackhex

  • status changed from new to assigned.

I'll apply it as soon as I'll get to Trac plugins development.

02/13/09 15:00:11 changed by anonymous

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in trunk with r5258. As soon as trunk will be tested enought, it will be merged to 0.11 branch.

Add/Change #4467 (rss links for posts, forums & messages)




Change Properties
Action