Modify

Opened 6 years ago

Closed 6 years ago

#4467 closed defect (fixed)

rss links for posts, forums & messages

Reported by: tkor@… Owned by: Blackhex
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Hi,

I recently had the problem of trying to use discussionplugin on a project I didnt have much time for, so I was in a kind of hassle. anyhow, trac did not generate clickable links in rss feeds (they were basically just file:///trac_env/... links, because "http://my.host.here" got omitted at the beginning of the link).

This happened ONLY in RSS mode, and I fixed it with a stupid workaround by hardcoding (yeah I know, but wth I am really no trac expert) the host name into timeline.py. There just HAS to be a better option than hardcoding; I just could not figure out how to get the base_url from there, but other than that, it fixes the problem for ONE trac environment.

Attached bad patch. anybody: DO NOT USE. JUST LOOK AT IT.

Attachments (2)

bad-bad-hardcoded-patch.diff (1.1 KB) - added by anonymous 6 years ago.
a really evil patch that cries out for a better way to be done. somehow.
4467-rss-links-base_url.patch (1.1 KB) - added by anonymous 6 years ago.
fixed to use base_url instead of hardcoded path.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by anonymous

a really evil patch that cries out for a better way to be done. somehow.

comment:1 Changed 6 years ago by tkor@…

okay, it was very easy.

will attach patch to fix it for good.

Changed 6 years ago by anonymous

fixed to use base_url instead of hardcoded path.

comment:2 Changed 6 years ago by Blackhex

  • Status changed from new to assigned

I'll apply it as soon as I'll get to Trac plugins development.

comment:3 Changed 6 years ago by anonymous

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in trunk with r5258. As soon as trunk will be tested enought, it will be merged to 0.11 branch.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.