Modify

Opened 5 years ago

Closed 4 years ago

#4525 closed defect (fixed)

[patch] SvnServePasswordStore looks at wrong place for svnserve.conf file

Reported by: luke at petre dot net Owned by: mrelbe
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: SvnServePasswordStore
Cc: rjollos Trac Release: 0.11

Description

By default the svnserve.conf file lives in /path/to/repos/conf/svnserve.conf. The SvnServePasswordStore looks in /path/to/repos/svnserve.conf

Attachments (1)

4525-svnserve.conf.path-7163.patch (837 bytes) - added by mrelbe 4 years ago.
Fixes this ticket

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by mrelbe

Fixes this ticket

comment:1 follow-up: Changed 4 years ago by mrelbe

  • Summary changed from SvnServePasswordStore does not look at the correct svnserve.conf file to [PATCH] SvnServePasswordStore does not look at the correct svnserve.conf file

Added attachment:4525-svnserve.conf.path-7163.patch

A no-brainer -- but this is my very first patch ever supplied to Trac/Trac-Hacks, and was therefore a suitable problem to practice "patching" on.

Please be gentle, guys.

comment:2 in reply to: ↑ 1 Changed 4 years ago by hasienda

  • Cc rjollos added
  • Owner changed from pacopablo to hasienda
  • Summary changed from [PATCH] SvnServePasswordStore does not look at the correct svnserve.conf file to [patch] SvnServePasswordStore looks at wrong place for svnserve.conf file

Replying to mrelbe:

Added attachment:4525-svnserve.conf.path-7163.patch

A no-brainer -- but this is my very first patch ever supplied to Trac/Trac-Hacks, and was therefore a suitable problem to practice "patching" on.

Oh, never mind. In fact, even a small typo could turn a good product into really bad user experience, so finding and correcting all kind of bugs and glitches is highly appreciated. Receive a 1+ for a ready-made patch.

Please be gentle, guys.

No response for so may months is not nice, indeed. Anyway I'll not only say "sorry" but allow your patch to go into trunk right now. Would you be so kind as to test it yourself? Short after taking over plugin maintenance here I still suffer a real test environment for this special propose. Hereby I award you premium permission to close this ticket, if you're able to test patched code successfully.

You may take a mental note to checkout further changes to AccountManagerPlugin within the next few weeks again. My Mercurial Queue is filling up with patches right now, most of them related to fixes and improvements to authentication/login form, new user registration and more equally important stuff.

comment:3 Changed 4 years ago by hasienda

(In [9251]) AccountManagerPlugin: Correct path in SvnServePasswordStore to look for svnserve.conf, refs #4525.

Thanks to Mikael Relbe for report and suggested fix.

comment:4 Changed 4 years ago by mrelbe

Hello -- this was not yesterday (no worries about time, I'm in the same boat :)

I'm currently not using SVN in this way, so I'll have to dig into my archives to verify this (and I'm about to switch computer and move from WinXP-32 to Win7-64).

Please give me-- umm --a month or so (not kidding).

comment:5 Changed 4 years ago by hasienda

  • Owner changed from hasienda to mrelbe

I've checked successfully against existing unittests. And I don't think, that some else is going on a faster lane right now to give us the feedback much earlier. So I'm ok with you taking as much time as you need.

Of course you may give "your" ticket back to me again anytime.

comment:6 Changed 4 years ago by mrelbe

  • Resolution set to fixed
  • Status changed from new to closed

I would probably forget this after a month, so I prioritized this...

It works!

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from mrelbe. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.