Ticket #456 (closed defect: worksforme)

Opened 6 years ago

Last modified 4 years ago

Link to download is not functioning

Reported by: Cowboy Assigned to: Blackhex
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.9

Description

Is there a problem with this plugin? I can not download because there is no link on the Wiki.

Thanks

Attachments

Change History

06/22/06 12:15:07 changed by cboos

  • status changed from new to closed.
  • resolution set to worksforme.

The InterMapTxt has been overwritten lately... I restored the download: prefix, but I guess a server restart would be needed (generic problem with IWikiChangeListeners...)

After that, the download:discussionplugin link should give you the proper download link, which is: http://trac-hacks.org/changeset/latest/discussionplugin?old_path=/&format=zip

(follow-up: ↓ 3 ) 06/22/06 23:27:58 changed by athomas

For AutoWikifyPlugin I found I had to add the following (hackish) code to clear the regex cache: 

WikiSystem(self.env)._compiled_rules = None

Something similar (or an additional method for doing this) would probably fix the problem.

InterMapTxt seems to have been overwritten by a wiki upgrade. This is probably not ideal.

(in reply to: ↑ 2 ; follow-up: ↓ 4 ) 06/23/06 00:13:11 changed by cboos

Replying to athomas:

Something similar (or an additional method for doing this) would probably fix the problem.

No, this is due to the fact of having multiple server processes for Trac, when using some web front-ends (i.e. mod_python, Apache prefork): the InterMapTxt save operation is done in one process, and by the way of the IWikiChangeListener that change is correctly propagated to the InterWikiMap component... but only inside that process, of course.

Subsequent requests reaching other processes still deal with InterWikiMap components that were not notified of the change.

Actually this is similar to the problem of updating the cached list of all Wiki pages. Currently the solution for this is quite heavy-weight (periodically refreshing the cache) and I think we should find a way to improve that in the future.


InterMapTxt seems to have been overwritten by a wiki upgrade. This is probably not ideal.

Eh, that's the risk for early adopters... But I'm afraid some kind of manual merge is always needed in such cases.

(in reply to: ↑ 3 ; follow-up: ↓ 5 ) 06/24/06 09:38:58 changed by athomas

Replying to cboos:

InterMapTxt seems to have been overwritten by a wiki upgrade. This is probably not ideal.

Eh, that's the risk for early adopters... But I'm afraid some kind of manual merge is always needed in such cases.

It seems like pretty bad form to overwrite a page which by design is meant to be modified by end users.

I suggest we add InterMapTxt to the page load ignore list in trac/scripts/admin.py: 

            self._do_wiki_load(default_dir('wiki'),
                               ignore=['WikiStart', 'checkwiki.py',
                                       'InterMapTxt'])

(in reply to: ↑ 4 ; follow-up: ↓ 6 ) 06/24/06 11:27:09 changed by cboos

Replying to athomas:

I suggest we add InterMapTxt to the page load ignore list in trac/scripts/admin.py: ...

Sure, I forgot about this feature.

(in reply to: ↑ 5 ) 06/24/06 11:31:22 changed by cboos

Replying to cboos:

Replying to athomas:

I suggest we add InterMapTxt to the page load ignore list in trac/scripts/admin.py: ...

Sure, I forgot about this feature.

Oops, not exactly what's needed, but I'll do something similar: only insert that page if it doesn't already exist.

Add/Change #456 (Link to download is not functioning)




Change Properties
Action