Opened 7 years ago

Closed 7 years ago

#456 closed defect (worksforme)

Reported by: Owned by: Cowboy Blackhex normal DiscussionPlugin normal 0.9

Description

Is there a problem with this plugin? I can not download because there is no link on the Wiki.

Thanks

comment:1 Changed 7 years ago by cboos

• Resolution set to worksforme
• Status changed from new to closed

The InterMapTxt has been overwritten lately...
server restart would be needed
(generic problem with IWikiChangeListeners...)

http://trac-hacks.org/changeset/latest/discussionplugin?old_path=/&format=zip

comment:2 follow-up: ↓ 3 Changed 7 years ago by athomas

For AutoWikifyPlugin I found I had to add the following (hackish) code to clear the regex cache:

WikiSystem(self.env)._compiled_rules = None


Something similar (or an additional method for doing this) would probably fix the problem.

InterMapTxt seems to have been overwritten by a wiki upgrade. This is probably not ideal.

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 7 years ago by cboos

Something similar (or an additional method for doing this) would probably fix the problem.

No, this is due to the fact of having multiple server processes for Trac,
when using some web front-ends (i.e. mod_python, Apache prefork):
the InterMapTxt save operation is done in one process, and by the way of
the IWikiChangeListener that change is correctly propagated to the InterWikiMap
component... but only inside that process, of course.

Subsequent requests reaching other processes still deal with InterWikiMap
components that were not notified of the change.

Actually this is similar to the problem of updating the cached list of
all Wiki pages. Currently the solution for this is quite heavy-weight
(periodically refreshing the cache) and I think we should find a way
to improve that in the future.

InterMapTxt seems to have been overwritten by a wiki upgrade. This is probably not ideal.

Eh, that's the risk for early adopters... But I'm afraid some kind
of manual merge is always needed in such cases.

comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed 7 years ago by athomas

InterMapTxt seems to have been overwritten by a wiki upgrade. This is probably not ideal.

Eh, that's the risk for early adopters... But I'm afraid some kind
of manual merge is always needed in such cases.

It seems like pretty bad form to overwrite a page which by design is meant to be modified by end users.

            self._do_wiki_load(default_dir('wiki'),
ignore=['WikiStart', 'checkwiki.py',
'InterMapTxt'])


...

comment:6 in reply to: ↑ 5 Changed 7 years ago by cboos

...

Oops, not exactly what's needed, but I'll do something similar:
only insert that page if it doesn't already exist.

Modify Ticket

Change Properties