Modify

Opened 5 years ago

Closed 5 years ago

#4624 closed defect (fixed)

r5160 breaks burndown chart by making default line transparent

Reported by: JasonWinnebeck Owned by: hoessler
Priority: normal Component: EstimationToolsPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.11

Description

source:estimationtoolsplugin/trunk/estimationtools/burndownchart.py@5160#L11 was modified in r5160 to change the default value of color from ff9900 to ff990000. Based on the Google Charts Color API, the fourth hex pair adjusts the transparency, of which 00 is fully transparent. Therefore, no lines appear on the graph when using default color option.

For example:
[[BurndownChart(milestone=release, startdate=2009-02-02)]]
Will draw a graph with a completely transparent line.

[[BurndownChart(milestone=release, startdate=2009-02-02, color=FF0000)]]
Will draw a graph with a solid red line. Therefore, specifying a color always is a workaround.

The commit message says that the background was made transparent, but it appears that actually the line was made transparent and the background made solid opaque white.

Patch:

  • estimationtools/burndownchart.py

     
    88from trac.wiki.macros import WikiMacroBase 
    99import copy 
    1010 
    11 DEFAULT_OPTIONS = {'width': '800', 'height': '200', 'color': 'ff990000', 'bgcolor': 'ffffff', 'wecolor':'f1f1f1'} 
     11DEFAULT_OPTIONS = {'width': '800', 'height': '200', 'color': 'ff9900', 'bgcolor': 'ffffff', 'wecolor':'f1f1f1'} 
    1212 
    1313class BurndownChart(WikiMacroBase): 
    1414    """Creates burn down chart for selected tickets. 

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by hoessler

  • Resolution set to fixed
  • Status changed from new to closed

(In [5265]) The lines shouldn't be transparent, but the default background. Fixes #4624.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hoessler. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.