r5160 breaks burndown chart by making default line transparent

[Jason Winnebeck]

source:estimationtoolsplugin/trunk/estimationtools/burndownchart.py@5160#L11​ was modified in r5160 to change the default value of color from ff9900 to ff990000. Based on the ​Google Charts Color API, the fourth hex pair adjusts the transparency, of which 00 is fully transparent. Therefore, no lines appear on the graph when using default color option.

For example: [[BurndownChart(milestone=release, startdate=2009-02-02)]] Will draw a graph with a completely transparent line.

[[BurndownChart(milestone=release, startdate=2009-02-02, color=FF0000)]] Will draw a graph with a solid red line. Therefore, specifying a color always is a workaround.

The commit message says that the background was made transparent, but it appears that actually the line was made transparent and the background made solid opaque white.

Patch:

estimationtools/burndownchart.py

@@ -8 +8 @@
 from trac.wiki.macros import WikiMacroBase
 import copy
 
-DEFAULT_OPTIONS = {'width': '800', 'height': '200', 'color': 'ff990000', 'bgcolor': 'ffffff', 'wecolor':'f1f1f1'}
+DEFAULT_OPTIONS = {'width': '800', 'height': '200', 'color': 'ff9900', 'bgcolor': 'ffffff', 'wecolor':'f1f1f1'}
 
 class BurndownChart(WikiMacroBase):
     """Creates burn down chart for selected tickets.

[Joachim Hoessler]

(In [5265]) The lines shouldn't be transparent, but the default background. Fixes #4624.