Ticket #5616 (closed defect: fixed)

Opened 8 months ago

Last modified 2 months ago

[Patch] Identical footnotes are not coalesced into one entry

Reported by: JoshuaH Assigned to: rjollos
Priority: normal Component: FootNoteMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

The documentation says that identical1 footnote references1 will be combined into a single footnote, but this doesn't seem to happen with the Trac 0.11 version of the plugin.

A patch that seems to fix this is attached.

  1. 1. like this

Attachments

FootNoteMacro-Fix-collation.patch (2.1 kB) - added by JoshuaH on 08/04/09 15:18:24.
Proposed patch

Change History

08/04/09 15:18:24 changed by JoshuaH

  • attachment FootNoteMacro-Fix-collation.patch added.

Proposed patch

02/03/10 08:09:47 changed by anonymous

  • summary changed from Footnotes are not automatically collated in the 0.11 plugin to [Patch] Footnotes are not automatically collated in the 0.11 plugin.

02/03/10 20:25:10 changed by rjollos

  • owner changed from athomas to rjollos.

Reassigning open tickets to myself since I am adopting this plugin.

02/04/10 03:39:38 changed by rjollos

  • status changed from new to assigned.

I'm seeing this behavior as well under Trac 0.12dev-r9098. I'll test out the patch.

02/04/10 03:43:15 changed by rjollos

  • summary changed from [Patch] Footnotes are not automatically collated in the 0.11 plugin to [Patch] Identical footnotes are not collated in the 0.11 plugin.

Clarification in comment:summary.

02/04/10 03:48:38 changed by rjollos

  • summary changed from [Patch] Identical footnotes are not collated in the 0.11 plugin to [Patch] Identical footnotes are not coalesced into one entry.

Further clarification in comment:summary.

02/04/10 03:48:52 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7501]) Applied patch from JoshuaH to fix issue with identical footnotes not bing coalesced into one entry. Fixed #5616.

02/04/10 04:04:20 changed by rjollos

In case a future regression arises, here is the markup I used to reproduce this error and verify the fix after patching. 

Testing out the th:FootNoteMacro [[FootNote(Here is the first
footnote)]]. This will be a good test[[FootNote(Here is the second
footnote)]]. And once again[[FootNote(Here is the second footnote)]]
[[FootNote(1)]].

Now I've test all of the documented behavior.

[[FootNote]]

We don't see this behavior on THO, presumably because it is running the 0.8 or 0.9 version of the plugin.

Testing out the th:FootNoteMacro 1. This will be a good test2. And once again2 1.

Now I've test all of the documented behavior.

  1. 1. Here is the first footnote
  2. 2. Here is the second footnote

Add/Change #5616 ([Patch] Identical footnotes are not coalesced into one entry)




Change Properties
Action