Modify

Opened 5 years ago

Closed 5 years ago

#5706 closed defect (duplicate)

[Patch] Remove obsolete jQuery syntax

Reported by: B.Ogryczak@… Owned by: CuriousCurmudgeon
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

This plugin uses JQuery 1.1 [@selectors] which are deprecated in JQuery 1.2 and removed completely in JQuery 1.3.
Easily fixable by removing @

Patch:

--- batchmod/templates/batchmod.html.orig       2008-10-12 20:57:00.000000000 +0200
+++ batchmod/templates/batchmod.html    2009-08-24 14:26:44.000000000 +0200
@@ -79,17 +79,17 @@
       $(this).before('<th class="bmod_selector"><input type="checkbox" name="bmod_toggleGroup" /></th>');
     }
   )
-  $("input[@name='bmod_toggleGroup']").click(function() {
+  $("input[name='bmod_toggleGroup']").click(function() {
     $("tr td input.bmod_selector",$(this).parents("table.listing")).attr("checked",this.checked);
   })
   <py:for each="field in fields">
-    $("input[@id=bmod_flag_${field.name}]").click(function() { $("*[@name=bmod_value_${field.name}]").enable(this.checked);} )
+    $("input[id=bmod_flag_${field.name}]").click(function() { $("*[name=bmod_value_${field.name}]").enable(this.checked);} )
   </py:for>
   $("input#bmod_flag_comment").click(function() {enableControl("bmod_value_comment",this.checked);} )
   $("form#batchmod-form").submit(function() {
     var selectedTix=[];
-    $("input[@name=selectedTicket]:checked").each( function(){ selectedTix.push(this.value);} );
-    $("input[@name=selectedTickets]").val(selectedTix);
+    $("input[name=selectedTicket]:checked").each( function(){ selectedTix.push(this.value);} );
+    $("input[name=selectedTickets]").val(selectedTix);
   })
   $(document.getElementById("columns")).toggleClass("collapsed");
 });

Attachments (0)

Change History (5)

comment:1 Changed 5 years ago by rjollos

  • Summary changed from obsolete JQuery syntax to Obsolete JQuery syntax

comment:2 Changed 5 years ago by rjollos

  • Owner changed from ashwin_phatak to CuriousCurmudgeon
  • Summary changed from Obsolete JQuery syntax to [Patch] Remove obsolete JQuery syntax

comment:3 follow-up: Changed 5 years ago by rjollos

  • Summary changed from [Patch] Remove obsolete JQuery syntax to [Patch] Remove obsolete jQuery syntax

Just looking through the tickets and noticed that this might potentially cause a problem on Trac 0.12, which may be moving to jQuery 1.3 according to some discussion I vaguely remember. The current 0.12dev still uses jQuery 1.2.6 though.

comment:4 in reply to: ↑ 3 Changed 5 years ago by CuriousCurmudgeon

  • Status changed from new to assigned

Replying to rjollos:

Just looking through the tickets and noticed that this might potentially cause a problem on Trac 0.12, which may be moving to jQuery 1.3 according to some discussion I vaguely remember. The current 0.12dev still uses jQuery 1.2.6 though.

There have been a number of tickets for this, but r7415 in #6012 removed the selectors. We should be fine on this issue if 0.12 moves to jQuery 1.3

comment:5 Changed 5 years ago by CuriousCurmudgeon

  • Resolution set to duplicate
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from CuriousCurmudgeon. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.