Modify

Opened 5 years ago

Closed 4 years ago

#6296 closed defect (fixed)

GitPlugin r6442: trac-admin resync repo.git fails

Reported by: lkraav Owned by: hvr
Priority: normal Component: GitPlugin
Severity: critical Keywords:
Cc: Trac Release: 0.11

Description (last modified by lkraav)

GitPlugin r7225, Python 2.5.4, not seeing any existing tickets:

  │2009-12-06 15:23:32,839 Trac[env] INFO: -------------------------------- environment startup [Trac 0.12multirepos-r8877] -----------------------------│
  │---                                                                                                                                                   │
  │2009-12-06 15:23:33,050 Trac[git_fs] INFO: detected GIT version 1.6.5                                                                                 │
  │2009-12-06 15:23:33,053 Trac[console] ERROR: Exception in trac-admin command:                                                                         │
  │Traceback (most recent call last):                                                                                                                    │
  │  File "build/bdist.linux-i686/egg/trac/admin/console.py", line 106, in onecmd                                                                        │
  │    rv = cmd.Cmd.onecmd(self, line) or 0                                                                                                              │
Ty│  File "/usr/lib/python2.5/cmd.py", line 218, in onecmd                                                                                               │
20│    return self.default(line)                                                                                                                         │
20│  File "build/bdist.linux-i686/egg/trac/admin/console.py", line 250, in default                                                                       │
20│    return cmd_mgr.execute_command(*args)                                                                                                             │
20│  File "build/bdist.linux-i686/egg/trac/admin/api.py", line 119, in execute_command                                                                   │
20│    return f(*fargs)                                                                                                                                  │
20│  File "build/bdist.linux-i686/egg/trac/versioncontrol/admin.py", line 142, in _do_resync                                                             │
20│    self._sync(reponame, rev, clean=True)                                                                                                             │
20│  File "build/bdist.linux-i686/egg/trac/versioncontrol/admin.py", line 113, in _sync                                                                  │
20│    repos = rm.get_repository(reponame, None)                                                                                                         │
20│  File "build/bdist.linux-i686/egg/trac/versioncontrol/api.py", line 499, in get_repository                                                           │
Tr│    repos = connector.get_repository(rtype, rdir, repoinfo.copy())                                                                                    │
  │  File "build/bdist.linux-i686/egg/tracext/git/git_fs.py", line 167, in get_repository                                                                │
  │    shortrev_len=self._shortrev_len)                                                                                                                  │
  │  File "build/bdist.linux-i686/egg/tracext/git/git_fs.py", line 185, in __init__                                                                      │
  │    Repository.__init__(self, "git:"+path, None, log)                                                                                                 │
  │TypeError: __init__() takes exactly 5 arguments (4 given)                                                                                             │

Attachments (0)

Change History (11)

comment:1 Changed 5 years ago by lkraav

GitPlugin r6442 that is

comment:2 Changed 5 years ago by roadrunner

There are two things that are odd:

  1. those line numbers don't match up with what's in r6442 - did you make local modifications to your git_fs.py?
  2. Which version of Trac are running _exactly_? Did you make your own modifications to core trac? Because Repository.__init__ takes only 4 arguments in Trac 0.10 (trac:browser:branches/0.10-stable/trac/versioncontrol/api.py#L129), 0.11 (trac:browser:branches/0.11-stable/trac/versioncontrol/api.py#L188), and even in current HEAD (trac:browser:trunk/trac/versioncontrol/api.py#L188).

comment:3 Changed 5 years ago by lkraav

first line of code:

environment startup [Trac 0.12multirepos-r8877]

this may be something multirepos specific. i just successfully installed gitplugin on 0.12dev-r8666

comment:4 Changed 5 years ago by lkraav

  • Description modified (diff)
  • Summary changed from trac-admin resync repo.git fails to GitPlugin r6442: trac-admin resync repo.git fails

small description change for mylyn

comment:5 Changed 5 years ago by cboos

Right, this is multirepos specific, things are currently in flux there (more breakage to come w.r.t Repository.__init__). I'll keep you informed via this ticket.

comment:6 Changed 4 years ago by lkraav

whats the latest on gitplugin + multirepos cboos?

comment:7 Changed 4 years ago by cboos

For multirepos, watch #T7116, this ticket will see the last changes to the API.

For the Git plugin, well, I've seen that Remy put that on the menu for PyCon's TracSprint ;-)

comment:8 Changed 4 years ago by cboos

See [T9082], the versioncontrol.api changes and [T9083], the Mercurial plugin adaptation (Repository and Changeset constructors have changed).

comment:9 Changed 4 years ago by cboos

Trac:MultiRepos is now on trunk.

The API changes are documented in Trac:wiki:TracDev/ApiChanges/0.12.

comment:10 Changed 4 years ago by lkraav

how is #6554 doing with taking care of this?

comment:11 Changed 4 years ago by lkraav

  • Resolution set to fixed
  • Status changed from new to closed

recent enough trac trunk (trac:r9125 and on) works well. closing this.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hvr. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.