Modify

Opened 5 years ago

#6500 new defect

Resubmit for Review button throws Unicode coersion error

Reported by: james.tait@… Owned by: viola
Priority: normal Component: CodeReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

I'm trialling this hack with a small team and have come across a problem. I have assigned myself CODE_REVIEW_DEV and CODE_REVIEW_MGR permissions, and my devs CODE_REVIEW_DEV permission. I created a new code review on r4097 of our repo, added a bunch of files that were newly added to the branch in that revision. I then went ahead with the review, adding comments to several files and ultimately rejecting the review. So far so good.

My developer then re-worked the files in question and committed the changes to the branch. At this point I'm not quite sure how it's supposed to work, but my assumption is that I click the Resubmit for Review button, select a new revision for the review and go through the process again. Unfortunately when I click the Resubmit for Review button I get the following error:

Traceback (most recent call last):
  File "C:\Python24\lib\site-packages\trac\web\main.py", line 387, in dispatch_request
    dispatcher.dispatch(req)
  File "C:\Python24\lib\site-packages\trac\web\main.py", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File "build\bdist.win32\egg\codereview\peerReviewNew.py", line 90, in process_request
TypeError: coercing to Unicode: need string or buffer, int found

I haven't attempted to investigate in the code.

We're using Trac 0.10.3.1 on Python 2.4 with a SQLite backend on Windows 2003.

Attachments (1)

CodeReviewPlugin-6500.diff (1.7 KB) - added by james.tait@… 5 years ago.
Patch to fix - tested on 0.10.

Download all attachments as: .zip

Change History (1)

Changed 5 years ago by james.tait@…

Patch to fix - tested on 0.10.

Add Comment

Modify Ticket

Action
as new The owner will remain viola.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.