Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6521 closed enhancement (fixed)

[Patch] Make the control stable while changing month and year, and make the brackets look better

Reported by: YouLi Owned by: anonymous
Priority: normal Component: WikiCalendarMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

  • The formatting of control over month and year looks confusing because the space between the double and single bracket is too small to tell the difference. This patch modifies the CSS part of code to make it look nicer.
  • We certainly don't want the control to move while we change month and year so a small table is created to ensure that.

Attachments (3)

patch.diff (3.3 KB) - added by YouLi 4 years ago.
diff file that shows the code changes
WikiCalendarMacroWith6521Patch.png (51.2 KB) - added by anonymous 4 years ago.
patch2.diff (844 bytes) - added by YouLi 4 years ago.
Fixed the bug: showbutton set to false now displays well

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by YouLi

diff file that shows the code changes

comment:1 Changed 4 years ago by rjollos

  • Summary changed from make the control stable while changing month and year, and make the brackets look better to [Patch] Make the control stable while changing month and year, and make the brackets look better

Thanks for the patch. Let me quickly test and then I will add to the repository.

comment:2 Changed 4 years ago by rjollos

  • Owner changed from rjollos to anonymous
  • Status changed from new to assigned
  • Type changed from defect to enhancement

There seems to be an issue with the patch when setting the third argument to false, for example, [[WikiCalendar(2006,07,false)]].

No image "WikiCalendarWith6521Patch.png" attached to Ticket #6521

Changed 4 years ago by anonymous

comment:3 Changed 4 years ago by rjollos

Accidentally caught another window when taking the screen capture, but you can see how the calendar is shifted to the right.


Changed 4 years ago by YouLi

Fixed the bug: showbutton set to false now displays well

comment:4 Changed 4 years ago by YouLi

The bug has been fixed, see attachment.

comment:5 Changed 4 years ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7502]) Applied patch from YouLi to improve positioning of month and year navigation brackets. Fixes #6521

comment:6 Changed 4 years ago by rjollos

Thanks for the patch. The improvement is nice. I added you to the Contributor list: WikiCalendarMacro#AuthorContributors

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from anonymous. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.