Ticket #6521 (closed enhancement: fixed)

Opened 2 months ago

Last modified 1 month ago

[Patch] Make the control stable while changing month and year, and make the brackets look better

Reported by: YouLi Assigned to: anonymous
Priority: normal Component: WikiCalendarMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

  • The formatting of control over month and year looks confusing because the space between the double and single bracket is too small to tell the difference. This patch modifies the CSS part of code to make it look nicer.
  • We certainly don't want the control to move while we change month and year so a small table is created to ensure that.

Attachments

patch.diff (3.3 kB) - added by YouLi on 02/02/10 17:57:55.
diff file that shows the code changes
WikiCalendarMacroWith6521Patch.png (51.2 kB) - added by anonymous on 02/03/10 03:23:43.
patch2.diff (0.8 kB) - added by YouLi on 02/04/10 13:47:43.
Fixed the bug: showbutton set to false now displays well

Change History

02/02/10 17:57:55 changed by YouLi

  • attachment patch.diff added.

diff file that shows the code changes

02/02/10 23:01:43 changed by rjollos

  • summary changed from make the control stable while changing month and year, and make the brackets look better to [Patch] Make the control stable while changing month and year, and make the brackets look better.

Thanks for the patch. Let me quickly test and then I will add to the repository.

02/03/10 03:21:52 changed by rjollos

  • owner changed from rjollos to anonymous.
  • status changed from new to assigned.
  • type changed from defect to enhancement.

There seems to be an issue with the patch when setting the third argument to false, for example, [[WikiCalendar(2006,07,false)]].

Error: Macro Image(WikiCalendarWith6521Patch.png) failed
Attachment #6521: WikiCalendarWith6521Patch.png does not exist.

02/03/10 03:23:43 changed by anonymous

  • attachment WikiCalendarMacroWith6521Patch.png added.

02/03/10 03:25:21 changed by rjollos

Accidentally caught another window when taking the screen capture, but you can see how the calendar is shifted to the right.

02/04/10 13:47:43 changed by YouLi

  • attachment patch2.diff added.

Fixed the bug: showbutton set to false now displays well

02/04/10 13:48:05 changed by YouLi

The bug has been fixed, see attachment.

02/04/10 20:09:22 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7502]) Applied patch from YouLi to improve positioning of month and year navigation brackets. Fixes #6521

02/04/10 20:10:53 changed by rjollos

Thanks for the patch. The improvement is nice. I added you to the Contributor list: WikiCalendarMacro#AuthorContributors

Add/Change #6521 ([Patch] Make the control stable while changing month and year, and make the brackets look better)




Change Properties
Action