Modify

Opened 8 years ago

Closed 8 years ago

#661 closed defect (fixed)

TocMacro titleindex argument - empty page list should list all pages.

Reported by: osimons Owned by: cboos
Priority: normal Component: TocMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Have had Trac projects running for close to a year, and earlier the [[TOC(titleindex) used to list all pages if no pages where supplied.

Now, it returns a titleindex only including the current page. Not a very useful titleindex.

Looked at the code, and suppose it has to do with how the list of pages is determined - where empty page list sets the list to current page. Correct in all other circumstances, but for title index it should fetch 'all' when list is empty.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by osimons

  • Type changed from enhancement to defect

comment:2 Changed 8 years ago by athomas

  • Owner changed from athomas to coderanger

comment:3 Changed 8 years ago by cboos

  • Owner changed from coderanger to cboos
  • Status changed from new to assigned
  • Trac Release changed from 0.9 to 0.11

Sounds good.

comment:4 Changed 8 years ago by cboos

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [1903]) Calling [[TOC(titleindex)]] now shows the table of content for all the pages. Fixes #661.

Refactored the expand_macro method to make it clearer and to be able to reuse the _render_title_index part.

Add Comment

Modify Ticket

Action
as closed The owner will remain cboos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.